Blame SOURCES/autofs-5.1.7-fix-flag-check-in-umount_multi.patch

96dc52
autofs-5.1.7 - fix flags check in umount_multi()
96dc52
96dc52
From: Ian Kent <raven@themaw.net>
96dc52
96dc52
Coverity: operator_confusion: "ap->flags | 1" is always 1/true
96dc52
	  regardless of the values of its operand.
96dc52
96dc52
Signed-off-by: Ian Kent <raven@themaw.net>
96dc52
---
96dc52
 CHANGELOG          |    1 +
96dc52
 daemon/automount.c |    2 +-
96dc52
 2 files changed, 2 insertions(+), 1 deletion(-)
96dc52
96dc52
diff --git a/CHANGELOG b/CHANGELOG
96dc52
index 9e385ba9..7add6c55 100644
96dc52
--- a/CHANGELOG
96dc52
+++ b/CHANGELOG
96dc52
@@ -56,6 +56,7 @@
96dc52
 - fix possible memory leak in mnts_add_amdmount().
96dc52
 - fix double unlock in parse_mount().
96dc52
 - add length check in umount_subtree_mounts().
96dc52
+- fix flags check in umount_multi().
96dc52
 
96dc52
 25/01/2021 autofs-5.1.7
96dc52
 - make bind mounts propagation slave by default.
96dc52
diff --git a/daemon/automount.c b/daemon/automount.c
96dc52
index 70506d83..23235a7d 100644
96dc52
--- a/daemon/automount.c
96dc52
+++ b/daemon/automount.c
96dc52
@@ -662,7 +662,7 @@ int umount_multi(struct autofs_point *ap, const char *path, int incl)
96dc52
 		/* Check if the autofs mount has browse mode enabled.
96dc52
 		 * If so re-create the directory entry.
96dc52
 		 */
96dc52
-		if (ap->flags | MOUNT_FLAG_GHOST) {
96dc52
+		if (ap->flags & MOUNT_FLAG_GHOST) {
96dc52
 			int ret;
96dc52
 
96dc52
 			/* If the browse directory create fails log an