Blame SOURCES/autofs-5.1.7-fix-double-unlock-in-parse_mount.patch

29d2b9
autofs-5.1.7 - fix double unlock in parse_mount()
29d2b9
29d2b9
From: Ian Kent <raven@themaw.net>
29d2b9
29d2b9
Coverity: double_unlock: "cache_unlock" unlocks "mc->rwlock" while it
29d2b9
	  is unlocked.
29d2b9
29d2b9
Signed-off-by: Ian Kent <raven@themaw.net>
29d2b9
---
29d2b9
 CHANGELOG           |    1 +
29d2b9
 modules/parse_sun.c |    1 -
29d2b9
 2 files changed, 1 insertion(+), 1 deletion(-)
29d2b9
29d2b9
diff --git a/CHANGELOG b/CHANGELOG
29d2b9
index 2e3b9fd7..224f58d6 100644
29d2b9
--- a/CHANGELOG
29d2b9
+++ b/CHANGELOG
29d2b9
@@ -54,6 +54,7 @@
29d2b9
 - remove redundant if check.
29d2b9
 - fix possible memory leak in master_parse().
29d2b9
 - fix possible memory leak in mnts_add_amdmount().
29d2b9
+- fix double unlock in parse_mount().
29d2b9
 
29d2b9
 25/01/2021 autofs-5.1.7
29d2b9
 - make bind mounts propagation slave by default.
29d2b9
diff --git a/modules/parse_sun.c b/modules/parse_sun.c
29d2b9
index a81d4028..05f53fc2 100644
29d2b9
--- a/modules/parse_sun.c
29d2b9
+++ b/modules/parse_sun.c
29d2b9
@@ -1526,7 +1526,6 @@ dont_expand:
29d2b9
 			if (!loc) {
29d2b9
 				free(options);
29d2b9
 				free(pmapent);
29d2b9
-				cache_unlock(mc);
29d2b9
 				warn(ap->logopt, MODPREFIX "out of memory");
29d2b9
 				return 1;
29d2b9
 			}