Blame SOURCES/autofs-5.1.7-fix-double-free-in-parse_mapent.patch

49b67f
autofs-5.1.7 - fix double free in parse_mapent()
49b67f
49b67f
From: Ian Kent <raven@themaw.net>
49b67f
49b67f
Coverity:
49b67f
in parse_mapent(): double_free: Calling "free" frees pointer "newopt"
49b67f
		   which has already been freed.
49b67f
49b67f
Signed-off-by: Ian Kent <raven@themaw.net>
49b67f
---
49b67f
 CHANGELOG           |    1 +
49b67f
 modules/parse_sun.c |    2 --
49b67f
 2 files changed, 1 insertion(+), 2 deletions(-)
49b67f
49b67f
--- autofs-5.1.4.orig/CHANGELOG
49b67f
+++ autofs-5.1.4/CHANGELOG
49b67f
@@ -62,6 +62,7 @@
49b67f
 - fix dead code in mnts_add_mount().
49b67f
 - fix arg not used in error print.
49b67f
 - fix missing lock release in mount_subtree().
49b67f
+- fix double free in parse_mapent().
49b67f
 
49b67f
 xx/xx/2018 autofs-5.1.5
49b67f
 - fix flag file permission.
49b67f
--- autofs-5.1.4.orig/modules/parse_sun.c
49b67f
+++ autofs-5.1.4/modules/parse_sun.c
49b67f
@@ -976,8 +976,6 @@ static int parse_mapent(const char *ent,
49b67f
 					estr = strerror_r(errno, buf, MAX_ERR_BUF);
49b67f
 					error(logopt, MODPREFIX
49b67f
 					      "concat_options: %s", estr);
49b67f
-					if (newopt)
49b67f
-						free(newopt);
49b67f
 					free(myoptions);
49b67f
 					return 0;
49b67f
 				}