Blame SOURCES/autofs-5.1.7-fix-dead-code-in-mnts_add_mount.patch
|
 |
beb904 |
autofs-5.1.7 - fix dead code in mnts_add_mount()
|
|
|
beb904 |
|
|
|
beb904 |
From: Ian Kent <raven@themaw.net>
|
|
|
beb904 |
|
|
|
beb904 |
Coverity: dead_error_line: Execution cannot reach this statement: "free(mp);".
|
|
|
beb904 |
|
|
|
beb904 |
Signed-off-by: Ian Kent <raven@themaw.net>
|
|
|
beb904 |
---
|
|
|
beb904 |
CHANGELOG | 1 +
|
|
|
beb904 |
lib/mounts.c | 8 ++------
|
|
|
beb904 |
2 files changed, 3 insertions(+), 6 deletions(-)
|
|
|
beb904 |
|
|
|
beb904 |
--- autofs-5.1.4.orig/CHANGELOG
|
|
|
beb904 |
+++ autofs-5.1.4/CHANGELOG
|
|
|
beb904 |
@@ -59,6 +59,7 @@
|
|
|
beb904 |
- fix flags check in umount_multi().
|
|
|
beb904 |
- dont try umount after stat() ENOENT fail.
|
|
|
beb904 |
- remove redundant assignment in master_add_amd_mount_section_mounts().
|
|
|
beb904 |
+- fix dead code in mnts_add_mount().
|
|
|
beb904 |
|
|
|
beb904 |
xx/xx/2018 autofs-5.1.5
|
|
|
beb904 |
- fix flag file permission.
|
|
|
beb904 |
--- autofs-5.1.4.orig/lib/mounts.c
|
|
|
beb904 |
+++ autofs-5.1.4/lib/mounts.c
|
|
|
beb904 |
@@ -1205,13 +1205,13 @@ struct mnt_list *mnts_add_mount(struct a
|
|
|
beb904 |
if (*name == '/') {
|
|
|
beb904 |
mp = strdup(name);
|
|
|
beb904 |
if (!mp)
|
|
|
beb904 |
- goto fail;
|
|
|
beb904 |
+ return NULL;
|
|
|
beb904 |
} else {
|
|
|
beb904 |
int len = ap->len + strlen(name) + 2;
|
|
|
beb904 |
|
|
|
beb904 |
mp = malloc(len);
|
|
|
beb904 |
if (!mp)
|
|
|
beb904 |
- goto fail;
|
|
|
beb904 |
+ return NULL;
|
|
|
beb904 |
strcpy(mp, ap->path);
|
|
|
beb904 |
strcat(mp, "/");
|
|
|
beb904 |
strcat(mp, name);
|
|
|
beb904 |
@@ -1228,10 +1228,6 @@ struct mnt_list *mnts_add_mount(struct a
|
|
|
beb904 |
free(mp);
|
|
|
beb904 |
|
|
|
beb904 |
return this;
|
|
|
beb904 |
-fail:
|
|
|
beb904 |
- if (mp)
|
|
|
beb904 |
- free(mp);
|
|
|
beb904 |
- return NULL;
|
|
|
beb904 |
}
|
|
|
beb904 |
|
|
|
beb904 |
void mnts_remove_mount(const char *mp, unsigned int flags)
|