|
 |
9a499a |
autofs-5.1.6 - fix empty mounts list return from unlink_mount_tree()
|
|
|
9a499a |
|
|
|
9a499a |
From: Ian Kent <raven@themaw.net>
|
|
|
9a499a |
|
|
|
9a499a |
If there are no appropriate mounts found by get_mnt_list() then
|
|
|
9a499a |
unlink_mount_tree() should return 1 not 0 since if there are no
|
|
|
9a499a |
mounts to umount this shouldn't cause a failure return.
|
|
|
9a499a |
|
|
|
9a499a |
Also, if a real error occurs in get_mnt_list() we should check for
|
|
|
9a499a |
it and return a failure from unlink_mount_tree() since that would
|
|
|
9a499a |
be mount table not found or out of memory. If that's ignored things
|
|
|
9a499a |
would only get worse from that point.
|
|
|
9a499a |
|
|
|
9a499a |
Signed-off-by: Ian Kent <raven@themaw.net>
|
|
|
9a499a |
---
|
|
|
9a499a |
CHANGELOG | 1 +
|
|
|
9a499a |
lib/mounts.c | 8 ++++++--
|
|
|
9a499a |
2 files changed, 7 insertions(+), 2 deletions(-)
|
|
|
9a499a |
|
|
|
9a499a |
--- autofs-5.1.4.orig/CHANGELOG
|
|
|
9a499a |
+++ autofs-5.1.4/CHANGELOG
|
|
|
9a499a |
@@ -75,6 +75,7 @@
|
|
|
9a499a |
- fix direct mount deadlock.
|
|
|
9a499a |
- fix lookup_prune_one_cache() refactoring change.
|
|
|
9a499a |
- add missing description of null map option.
|
|
|
9a499a |
+- fix empty mounts list return from unlink_mount_tree().
|
|
|
9a499a |
|
|
|
9a499a |
xx/xx/2018 autofs-5.1.5
|
|
|
9a499a |
- fix flag file permission.
|
|
|
9a499a |
--- autofs-5.1.4.orig/lib/mounts.c
|
|
|
9a499a |
+++ autofs-5.1.4/lib/mounts.c
|
|
|
9a499a |
@@ -2115,9 +2115,13 @@ int unlink_mount_tree(struct autofs_poin
|
|
|
9a499a |
struct mnt_list *mnts, *mnt;
|
|
|
9a499a |
int rv, ret = 1;
|
|
|
9a499a |
|
|
|
9a499a |
+ errno = 0;
|
|
|
9a499a |
mnts = get_mnt_list(mp, 1);
|
|
|
9a499a |
- if (!mnts)
|
|
|
9a499a |
- return 0;
|
|
|
9a499a |
+ if (!mnts) {
|
|
|
9a499a |
+ if (errno)
|
|
|
9a499a |
+ return 0;
|
|
|
9a499a |
+ return 1;
|
|
|
9a499a |
+ }
|
|
|
9a499a |
|
|
|
9a499a |
for (mnt = mnts; mnt; mnt = mnt->next) {
|
|
|
9a499a |
if (mnt->flags & MNTS_AUTOFS)
|