Blame SOURCES/autofs-5.1.4-dont-use-array-for-path-when-not-neccessary.patch

306fa1
autofs-5.1.4 - dont use array for path when not necessary
306fa1
306fa1
From: Ian Kent <raven@themaw.net>
306fa1
306fa1
In parse_amd.c:do_link_mount() a character array is used to construct
306fa1
a path when a pointer to the relevant amd entry field is sufficient.
306fa1
306fa1
Signed-off-by: Ian Kent <raven@themaw.net>
306fa1
---
306fa1
 CHANGELOG           |    1 +
306fa1
 modules/parse_amd.c |    6 +++---
306fa1
 2 files changed, 4 insertions(+), 3 deletions(-)
306fa1
306fa1
--- autofs-5.0.7.orig/CHANGELOG
306fa1
+++ autofs-5.0.7/CHANGELOG
306fa1
@@ -291,6 +291,7 @@
306fa1
 - serialize calls to open_xxxx() functions.
306fa1
 - fix use after free in do_master_list_reset().
306fa1
 - fix deadlock in dumpmaps.
306fa1
+- dont use array for path when not necessary.
306fa1
 
306fa1
 25/07/2012 autofs-5.0.7
306fa1
 =======================
306fa1
--- autofs-5.0.7.orig/modules/parse_amd.c
306fa1
+++ autofs-5.0.7/modules/parse_amd.c
306fa1
@@ -969,8 +969,8 @@ static int do_auto_mount(struct autofs_p
306fa1
 static int do_link_mount(struct autofs_point *ap, const char *name,
306fa1
 			 struct amd_entry *entry, unsigned int flags)
306fa1
 {
306fa1
-	char target[PATH_MAX + 1];
306fa1
 	const char *opts = (entry->opts && *entry->opts) ? entry->opts : NULL;
306fa1
+	char *target;
306fa1
 	int ret;
306fa1
 
306fa1
 	if (entry->sublink) {
306fa1
@@ -979,14 +979,14 @@ static int do_link_mount(struct autofs_p
306fa1
 			     "error: sublink option length is too long");
306fa1
 			return 0;
306fa1
 		}
306fa1
-		strcpy(target, entry->sublink);
306fa1
+		target = entry->sublink;
306fa1
 	} else {
306fa1
 		if (strlen(entry->fs) > PATH_MAX) {
306fa1
 			error(ap->logopt, MODPREFIX
306fa1
 			     "error: fs option length is too long");
306fa1
 			return 0;
306fa1
 		}
306fa1
-		strcpy(target, entry->fs);
306fa1
+		target = entry->fs;
306fa1
 	}
306fa1
 
306fa1
 	if (!(flags & CONF_AUTOFS_USE_LOFS))