Blame SOURCES/autofs-5.1.2-factor-out-set-thread-mount-request-log-id.patch

4d476f
autofs-5.1.2 - factor out set_thread_mount_request_log_id()
4d476f
4d476f
From: Ian Kent <raven@themaw.net>
4d476f
4d476f
Factor out setting the thread mount request log id.
4d476f
4d476f
Signed-off-by: Ian Kent <raven@themaw.net>
4d476f
---
4d476f
 CHANGELOG           |    1 +
4d476f
 daemon/automount.c  |   24 +++++++++++++++++++++++-
4d476f
 daemon/direct.c     |   17 +----------------
4d476f
 daemon/indirect.c   |   17 +----------------
4d476f
 include/automount.h |    3 ++-
4d476f
 5 files changed, 28 insertions(+), 34 deletions(-)
4d476f
4d476f
--- autofs-5.0.7.orig/CHANGELOG
4d476f
+++ autofs-5.0.7/CHANGELOG
4d476f
@@ -238,6 +238,7 @@
4d476f
 - add the mount requestor's pid to pending_args.
4d476f
 - create thread-local ID for mount attempts.
4d476f
 - log functions to prefix messages with attempt_id if available.
4d476f
+- factor out set_thread_mount_request_log_id().
4d476f
 
4d476f
 25/07/2012 autofs-5.0.7
4d476f
 =======================
4d476f
--- autofs-5.0.7.orig/daemon/automount.c
4d476f
+++ autofs-5.0.7/daemon/automount.c
4d476f
@@ -100,7 +100,7 @@ static int umount_all(struct autofs_poin
4d476f
 extern struct master *master_list;
4d476f
 
4d476f
 /* simple string hash based on public domain sdbm library */
4d476f
-unsigned long sdbm_hash(const char *str, unsigned long seed)
4d476f
+static unsigned long sdbm_hash(const char *str, unsigned long seed)
4d476f
 {
4d476f
 	unsigned long hash = seed;
4d476f
 	char c;
4d476f
@@ -110,6 +110,28 @@ unsigned long sdbm_hash(const char *str,
4d476f
 	return hash;
4d476f
 }
4d476f
 
4d476f
+void set_thread_mount_request_log_id(struct pending_args *mt)
4d476f
+{
4d476f
+	char attempt_id_comp[20];
4d476f
+	unsigned long *attempt_id;
4d476f
+	int status;
4d476f
+
4d476f
+	attempt_id = pthread_getspecific(key_thread_attempt_id);
4d476f
+	if (attempt_id == NULL) {
4d476f
+		attempt_id = (unsigned long *) calloc(1, sizeof(unsigned long));
4d476f
+		if (attempt_id  == NULL)
4d476f
+			fatal(ENOMEM);
4d476f
+		snprintf(attempt_id_comp, 20, "%ld", mt->wait_queue_token);
4d476f
+		*attempt_id = sdbm_hash(attempt_id_comp, 0);
4d476f
+		snprintf(attempt_id_comp, 20, "%u", mt->pid);
4d476f
+		*attempt_id = sdbm_hash(attempt_id_comp, *attempt_id);
4d476f
+		*attempt_id = sdbm_hash(mt->name, *attempt_id);
4d476f
+		status = pthread_setspecific(key_thread_attempt_id, attempt_id);
4d476f
+		if (status != 0)
4d476f
+			fatal(status);
4d476f
+	}
4d476f
+}
4d476f
+
4d476f
 static int do_mkdir(const char *parent, const char *path, mode_t mode)
4d476f
 {
4d476f
 	int status;
4d476f
--- autofs-5.0.7.orig/daemon/direct.c
4d476f
+++ autofs-5.0.7/daemon/direct.c
4d476f
@@ -1210,8 +1210,6 @@ static void *do_mount_direct(void *arg)
4d476f
 	struct autofs_point *ap;
4d476f
 	struct stat st;
4d476f
 	int status, state;
4d476f
-	char attempt_id_comp[20];
4d476f
-	unsigned long *attempt_id;
4d476f
 
4d476f
 	args = (struct pending_args *) arg;
4d476f
 
4d476f
@@ -1221,20 +1219,7 @@ static void *do_mount_direct(void *arg)
4d476f
 
4d476f
 	ap = mt.ap;
4d476f
 
4d476f
-	attempt_id = pthread_getspecific(key_thread_attempt_id);
4d476f
-	if (attempt_id == NULL) {
4d476f
-		attempt_id = (unsigned long *) calloc(1, sizeof(unsigned long));
4d476f
-		if (attempt_id == NULL)
4d476f
-			fatal(ENOMEM);
4d476f
-		snprintf(attempt_id_comp, 20, "%ld", mt.wait_queue_token);
4d476f
-		*attempt_id = sdbm_hash(attempt_id_comp, 0);
4d476f
-		snprintf(attempt_id_comp, 20, "%u", mt.pid);
4d476f
-		*attempt_id = sdbm_hash(attempt_id_comp, *attempt_id);
4d476f
-		*attempt_id = sdbm_hash(mt.name, *attempt_id);
4d476f
-		status = pthread_setspecific(key_thread_attempt_id, attempt_id);
4d476f
-		if (status != 0)
4d476f
-			fatal(status);
4d476f
-	}
4d476f
+	set_thread_mount_request_log_id(&mt;;
4d476f
 
4d476f
 	args->signaled = 1;
4d476f
 	status = pthread_cond_signal(&args->cond);
4d476f
--- autofs-5.0.7.orig/daemon/indirect.c
4d476f
+++ autofs-5.0.7/daemon/indirect.c
4d476f
@@ -726,8 +726,6 @@ static void *do_mount_indirect(void *arg
4d476f
 	char buf[PATH_MAX + 1];
4d476f
 	struct stat st;
4d476f
 	int len, status, state;
4d476f
-	char attempt_id_comp[20];
4d476f
-	unsigned long *attempt_id;
4d476f
 
4d476f
 	args = (struct pending_args *) arg;
4d476f
 
4d476f
@@ -737,20 +735,7 @@ static void *do_mount_indirect(void *arg
4d476f
 
4d476f
 	ap = mt.ap;
4d476f
 
4d476f
-	attempt_id = pthread_getspecific(key_thread_attempt_id);
4d476f
-	if (attempt_id == NULL) {
4d476f
-		attempt_id = (unsigned long *) calloc(1, sizeof(unsigned long));
4d476f
-		if (attempt_id  == NULL)
4d476f
-			fatal(ENOMEM);
4d476f
-		snprintf(attempt_id_comp, 20, "%ld", mt.wait_queue_token);
4d476f
-		*attempt_id = sdbm_hash(attempt_id_comp, 0);
4d476f
-		snprintf(attempt_id_comp, 20, "%u", mt.pid);
4d476f
-		*attempt_id = sdbm_hash(attempt_id_comp, *attempt_id);
4d476f
-		*attempt_id = sdbm_hash(mt.name, *attempt_id);
4d476f
-		status = pthread_setspecific(key_thread_attempt_id, attempt_id);
4d476f
-		if (status != 0)
4d476f
-			fatal(status);
4d476f
-	}
4d476f
+	set_thread_mount_request_log_id(&mt;;
4d476f
 
4d476f
 	args->signaled = 1;
4d476f
 	status = pthread_cond_signal(&args->cond);
4d476f
--- autofs-5.0.7.orig/include/automount.h
4d476f
+++ autofs-5.0.7/include/automount.h
4d476f
@@ -243,7 +243,8 @@ const char **copy_argv(int argc, const c
4d476f
 int compare_argv(int argc1, const char **argv1, int argc2, const char **argv2);
4d476f
 int free_argv(int argc, const char **argv);
4d476f
 
4d476f
-unsigned long sdbm_hash(const char *str, unsigned long seed);
4d476f
+struct pending_args;
4d476f
+void set_thread_mount_request_log_id(struct pending_args *mt);
4d476f
 
4d476f
 void dump_core(void);
4d476f
 int aquire_lock(void);