|
 |
4d476f |
autofs-5.1.0 - check options length before use in parse_amd.c
|
|
|
4d476f |
|
|
|
4d476f |
From: Ian Kent <ikent@redhat.com>
|
|
|
4d476f |
|
|
|
4d476f |
Check for temporary buffer overflow before copy at several places in
|
|
|
4d476f |
modules/parse_amd.c.
|
|
|
4d476f |
---
|
|
|
4d476f |
CHANGELOG | 1 +
|
|
|
4d476f |
modules/parse_amd.c | 36 ++++++++++++++++++++++++++++++++----
|
|
|
4d476f |
2 files changed, 33 insertions(+), 4 deletions(-)
|
|
|
4d476f |
|
|
|
4d476f |
--- autofs-5.0.7.orig/CHANGELOG
|
|
|
4d476f |
+++ autofs-5.0.7/CHANGELOG
|
|
|
4d476f |
@@ -141,6 +141,7 @@
|
|
|
4d476f |
- check amd lex buffer len before copy.
|
|
|
4d476f |
- add return check in ldap check_map_indirect().
|
|
|
4d476f |
- check host macro is set before use.
|
|
|
4d476f |
+- check options length before use in parse_amd.c.
|
|
|
4d476f |
|
|
|
4d476f |
25/07/2012 autofs-5.0.7
|
|
|
4d476f |
=======================
|
|
|
4d476f |
--- autofs-5.0.7.orig/modules/parse_amd.c
|
|
|
4d476f |
+++ autofs-5.0.7/modules/parse_amd.c
|
|
|
4d476f |
@@ -906,9 +906,20 @@ static int do_auto_mount(struct autofs_p
|
|
|
4d476f |
{
|
|
|
4d476f |
char target[PATH_MAX + 1];
|
|
|
4d476f |
|
|
|
4d476f |
- if (!entry->map_type)
|
|
|
4d476f |
+ if (!entry->map_type) {
|
|
|
4d476f |
+ if (strlen(entry->fs) > PATH_MAX) {
|
|
|
4d476f |
+ error(ap->logopt, MODPREFIX
|
|
|
4d476f |
+ "error: fs option length is too long");
|
|
|
4d476f |
+ return 0;
|
|
|
4d476f |
+ }
|
|
|
4d476f |
strcpy(target, entry->fs);
|
|
|
4d476f |
- else {
|
|
|
4d476f |
+ } else {
|
|
|
4d476f |
+ if (strlen(entry->fs) +
|
|
|
4d476f |
+ strlen(entry->map_type) + 5 > PATH_MAX) {
|
|
|
4d476f |
+ error(ap->logopt, MODPREFIX
|
|
|
4d476f |
+ "error: fs + maptype options length is too long");
|
|
|
4d476f |
+ return 0;
|
|
|
4d476f |
+ }
|
|
|
4d476f |
strcpy(target, entry->map_type);
|
|
|
4d476f |
strcat(target, ",amd:");
|
|
|
4d476f |
strcat(target, entry->fs);
|
|
|
4d476f |
@@ -925,10 +936,21 @@ static int do_link_mount(struct autofs_p
|
|
|
4d476f |
const char *opts = (entry->opts && *entry->opts) ? entry->opts : NULL;
|
|
|
4d476f |
int ret;
|
|
|
4d476f |
|
|
|
4d476f |
- if (entry->sublink)
|
|
|
4d476f |
+ if (entry->sublink) {
|
|
|
4d476f |
+ if (strlen(entry->sublink) > PATH_MAX) {
|
|
|
4d476f |
+ error(ap->logopt, MODPREFIX
|
|
|
4d476f |
+ "error: sublink option length is too long");
|
|
|
4d476f |
+ return 0;
|
|
|
4d476f |
+ }
|
|
|
4d476f |
strcpy(target, entry->sublink);
|
|
|
4d476f |
- else
|
|
|
4d476f |
+ } else {
|
|
|
4d476f |
+ if (strlen(entry->fs) > PATH_MAX) {
|
|
|
4d476f |
+ error(ap->logopt, MODPREFIX
|
|
|
4d476f |
+ "error: fs option length is too long");
|
|
|
4d476f |
+ return 0;
|
|
|
4d476f |
+ }
|
|
|
4d476f |
strcpy(target, entry->fs);
|
|
|
4d476f |
+ }
|
|
|
4d476f |
|
|
|
4d476f |
if (!(flags & CONF_AUTOFS_USE_LOFS))
|
|
|
4d476f |
goto symlink;
|
|
|
4d476f |
@@ -1017,6 +1039,12 @@ static int do_nfs_mount(struct autofs_po
|
|
|
4d476f |
unsigned int umount = 0;
|
|
|
4d476f |
int ret = 0;
|
|
|
4d476f |
|
|
|
4d476f |
+ if (strlen(entry->rhost) + strlen(entry->rfs) + 1 > PATH_MAX) {
|
|
|
4d476f |
+ error(ap->logopt, MODPREFIX
|
|
|
4d476f |
+ "error: rhost + rfs options length is too long");
|
|
|
4d476f |
+ return 0;
|
|
|
4d476f |
+ }
|
|
|
4d476f |
+
|
|
|
4d476f |
strcpy(target, entry->rhost);
|
|
|
4d476f |
strcat(target, ":");
|
|
|
4d476f |
strcat(target, entry->rfs);
|