Blame SOURCES/apr-util-1.6.1-CVE-2022-25147.patch

3dbb84
diff --git a/encoding/apr_base64.c b/encoding/apr_base64.c
3dbb84
index 1eed153..2803106 100644
3dbb84
--- a/encoding/apr_base64.c
3dbb84
+++ b/encoding/apr_base64.c
3dbb84
@@ -20,11 +20,20 @@
3dbb84
  * ugly 'len' functions, which is quite a nasty cost.
3dbb84
  */
3dbb84
 
3dbb84
+#undef NDEBUG /* always abort() on assert()ion failure */
3dbb84
+#include <assert.h>
3dbb84
+
3dbb84
 #include "apr_base64.h"
3dbb84
 #if APR_CHARSET_EBCDIC
3dbb84
 #include "apr_xlate.h"
3dbb84
 #endif				/* APR_CHARSET_EBCDIC */
3dbb84
 
3dbb84
+/* Above APR_BASE64_ENCODE_MAX length the encoding can't fit in an int >= 0 */
3dbb84
+#define APR_BASE64_ENCODE_MAX 1610612733
3dbb84
+
3dbb84
+/* Above APR_BASE64_DECODE_MAX length the decoding can't fit in an int >= 0 */
3dbb84
+#define APR_BASE64_DECODE_MAX 2863311524u
3dbb84
+
3dbb84
 /* aaaack but it's fast and const should make it shared text page. */
3dbb84
 static const unsigned char pr2six[256] =
3dbb84
 {
3dbb84
@@ -109,7 +118,6 @@ APU_DECLARE(apr_status_t) apr_base64init_ebcdic(apr_xlate_t *to_ascii,
3dbb84
 
3dbb84
 APU_DECLARE(int) apr_base64_decode_len(const char *bufcoded)
3dbb84
 {
3dbb84
-    int nbytesdecoded;
3dbb84
     register const unsigned char *bufin;
3dbb84
     register apr_size_t nprbytes;
3dbb84
 
3dbb84
@@ -117,16 +125,16 @@ APU_DECLARE(int) apr_base64_decode_len(const char *bufcoded)
3dbb84
     while (pr2six[*(bufin++)] <= 63);
3dbb84
 
3dbb84
     nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;
3dbb84
-    nbytesdecoded = (((int)nprbytes + 3) / 4) * 3;
3dbb84
+    assert(nprbytes <= APR_BASE64_DECODE_MAX);
3dbb84
 
3dbb84
-    return nbytesdecoded + 1;
3dbb84
+    return (int)(((nprbytes + 3u) / 4u) * 3u + 1u);
3dbb84
 }
3dbb84
 
3dbb84
 APU_DECLARE(int) apr_base64_decode(char *bufplain, const char *bufcoded)
3dbb84
 {
3dbb84
 #if APR_CHARSET_EBCDIC
3dbb84
     apr_size_t inbytes_left, outbytes_left;
3dbb84
-#endif				/* APR_CHARSET_EBCDIC */
3dbb84
+#endif	/* APR_CHARSET_EBCDIC */
3dbb84
     int len;
3dbb84
     
3dbb84
     len = apr_base64_decode_binary((unsigned char *) bufplain, bufcoded);
3dbb84
@@ -153,12 +161,13 @@ APU_DECLARE(int) apr_base64_decode_binary(unsigned char *bufplain,
3dbb84
     bufin = (const unsigned char *) bufcoded;
3dbb84
     while (pr2six[*(bufin++)] <= 63);
3dbb84
     nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;
3dbb84
-    nbytesdecoded = (((int)nprbytes + 3) / 4) * 3;
3dbb84
+    assert(nprbytes <= APR_BASE64_DECODE_MAX);
3dbb84
+    nbytesdecoded = (int)(((nprbytes + 3u) / 4u) * 3u);
3dbb84
 
3dbb84
     bufout = (unsigned char *) bufplain;
3dbb84
     bufin = (const unsigned char *) bufcoded;
3dbb84
 
3dbb84
-    while (nprbytes > 4) {
3dbb84
+    while (nprbytes >= 4) {
3dbb84
 	*(bufout++) =
3dbb84
 	    (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);
3dbb84
 	*(bufout++) =
3dbb84
@@ -178,13 +187,8 @@ APU_DECLARE(int) apr_base64_decode_binary(unsigned char *bufplain,
3dbb84
 	*(bufout++) =
3dbb84
 	    (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);
3dbb84
     }
3dbb84
-    if (nprbytes > 3) {
3dbb84
-	*(bufout++) =
3dbb84
-	    (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);
3dbb84
-    }
3dbb84
 
3dbb84
-    nbytesdecoded -= (4 - (int)nprbytes) & 3;
3dbb84
-    return nbytesdecoded;
3dbb84
+    return nbytesdecoded - (int)((4u - nprbytes) & 3u);
3dbb84
 }
3dbb84
 
3dbb84
 static const char basis_64[] =
3dbb84
@@ -192,6 +196,8 @@ static const char basis_64[] =
3dbb84
 
3dbb84
 APU_DECLARE(int) apr_base64_encode_len(int len)
3dbb84
 {
3dbb84
+    assert(len >= 0 && len <= APR_BASE64_ENCODE_MAX);
3dbb84
+
3dbb84
     return ((len + 2) / 3 * 4) + 1;
3dbb84
 }
3dbb84
 
3dbb84
@@ -203,6 +209,8 @@ APU_DECLARE(int) apr_base64_encode(char *encoded, const char *string, int len)
3dbb84
     int i;
3dbb84
     char *p;
3dbb84
 
3dbb84
+    assert(len >= 0 && len <= APR_BASE64_ENCODE_MAX);
3dbb84
+
3dbb84
     p = encoded;
3dbb84
     for (i = 0; i < len - 2; i += 3) {
3dbb84
 	*p++ = basis_64[(os_toascii[string[i]] >> 2) & 0x3F];
3dbb84
@@ -227,7 +235,7 @@ APU_DECLARE(int) apr_base64_encode(char *encoded, const char *string, int len)
3dbb84
     }
3dbb84
 
3dbb84
     *p++ = '\0';
3dbb84
-    return p - encoded;
3dbb84
+    return (unsigned int)(p - encoded);
3dbb84
 #endif				/* APR_CHARSET_EBCDIC */
3dbb84
 }
3dbb84
 
3dbb84
@@ -240,6 +248,8 @@ APU_DECLARE(int) apr_base64_encode_binary(char *encoded,
3dbb84
     int i;
3dbb84
     char *p;
3dbb84
 
3dbb84
+    assert(len >= 0 && len <= APR_BASE64_ENCODE_MAX);
3dbb84
+
3dbb84
     p = encoded;
3dbb84
     for (i = 0; i < len - 2; i += 3) {
3dbb84
 	*p++ = basis_64[(string[i] >> 2) & 0x3F];
3dbb84
@@ -264,5 +274,5 @@ APU_DECLARE(int) apr_base64_encode_binary(char *encoded,
3dbb84
     }
3dbb84
 
3dbb84
     *p++ = '\0';
3dbb84
-    return (int)(p - encoded);
3dbb84
+    return (unsigned int)(p - encoded);
3dbb84
 }