|
 |
78a2f7 |
From c4d4ecdad1259aab4c27db291e1dfcef0b1a6a51 Mon Sep 17 00:00:00 2001
|
|
|
78a2f7 |
From: Jakub Filak <jfilak@redhat.com>
|
|
|
78a2f7 |
Date: Wed, 22 Jan 2014 15:33:50 +0100
|
|
|
78a2f7 |
Subject: [PATCH 40/40] Fix a pair of defects uncovered by coverity
|
|
|
78a2f7 |
|
|
|
78a2f7 |
Resolves rhbz#1056584
|
|
|
78a2f7 |
---
|
|
|
78a2f7 |
src/abrt-checker.c | 8 ++++++--
|
|
|
78a2f7 |
src/jthread_map.c | 1 +
|
|
|
78a2f7 |
2 files changed, 7 insertions(+), 2 deletions(-)
|
|
|
78a2f7 |
|
|
|
78a2f7 |
diff --git a/src/abrt-checker.c b/src/abrt-checker.c
|
|
|
78a2f7 |
index 91485e0..713053c 100644
|
|
|
78a2f7 |
--- a/src/abrt-checker.c
|
|
|
78a2f7 |
+++ b/src/abrt-checker.c
|
|
|
78a2f7 |
@@ -2886,7 +2886,11 @@ void parse_commandline_options(char *options)
|
|
|
78a2f7 |
}
|
|
|
78a2f7 |
else if (strcmp("executable", key) == 0)
|
|
|
78a2f7 |
{
|
|
|
78a2f7 |
- if (strcmp("threadclass", value) == 0)
|
|
|
78a2f7 |
+ if (NULL == value || '\0' == value[0])
|
|
|
78a2f7 |
+ {
|
|
|
78a2f7 |
+ fprintf(stderr, "A value of '%s' option cannot be empty\n", key);
|
|
|
78a2f7 |
+ }
|
|
|
78a2f7 |
+ else if (strcmp("threadclass", value) == 0)
|
|
|
78a2f7 |
{
|
|
|
78a2f7 |
VERBOSE_PRINT("Use a thread class for 'executable'\n");
|
|
|
78a2f7 |
executableFlags |= ABRT_EXECUTABLE_THREAD;
|
|
|
78a2f7 |
@@ -2899,7 +2903,7 @@ void parse_commandline_options(char *options)
|
|
|
78a2f7 |
}
|
|
|
78a2f7 |
else
|
|
|
78a2f7 |
{
|
|
|
78a2f7 |
- fprintf(stderr, "Unknown 'executable' option's value '%s'\n", key);
|
|
|
78a2f7 |
+ fprintf(stderr, "Unknown '%s' option's value '%s'\n", key, value);
|
|
|
78a2f7 |
}
|
|
|
78a2f7 |
}
|
|
|
78a2f7 |
else
|
|
|
78a2f7 |
diff --git a/src/jthread_map.c b/src/jthread_map.c
|
|
|
78a2f7 |
index 4517398..4cb417b 100644
|
|
|
78a2f7 |
--- a/src/jthread_map.c
|
|
|
78a2f7 |
+++ b/src/jthread_map.c
|
|
|
78a2f7 |
@@ -55,6 +55,7 @@ T_jthreadMap *jthread_map_new()
|
|
|
78a2f7 |
if (NULL == map)
|
|
|
78a2f7 |
{
|
|
|
78a2f7 |
fprintf(stderr, __FILE__ ":" STRINGIZE(__LINE__) ": calloc() error\n");
|
|
|
78a2f7 |
+ return NULL;
|
|
|
78a2f7 |
}
|
|
|
78a2f7 |
|
|
|
78a2f7 |
pthread_mutex_init(&map->mutex, /*use default attributes*/NULL);
|
|
|
78a2f7 |
--
|
|
|
78a2f7 |
1.8.3.1
|
|
|
78a2f7 |
|