|
 |
8d63ce |
From 9b2eee24768889378032077423cb6a3221a8ad18 Mon Sep 17 00:00:00 2001
|
|
|
8d63ce |
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
|
|
|
8d63ce |
Date: Thu, 14 Feb 2019 15:41:47 +0100
|
|
|
8d63ce |
Subject: [PATCH] CVE-2019-7574: Fix a buffer overread in IMA_ADPCM_decode
|
|
|
8d63ce |
MIME-Version: 1.0
|
|
|
8d63ce |
Content-Type: text/plain; charset=UTF-8
|
|
|
8d63ce |
Content-Transfer-Encoding: 8bit
|
|
|
8d63ce |
|
|
|
8d63ce |
If data chunk was shorter than expected based on a WAV format
|
|
|
8d63ce |
definition, IMA_ADPCM_decode() tried to read past the data chunk
|
|
|
8d63ce |
buffer. This patch fixes it.
|
|
|
8d63ce |
|
|
|
8d63ce |
CVE-2019-7574
|
|
|
8d63ce |
https://bugzilla.libsdl.org/show_bug.cgi?id=4496
|
|
|
8d63ce |
|
|
|
8d63ce |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
8d63ce |
---
|
|
|
8d63ce |
src/audio/SDL_wave.c | 9 ++++++++-
|
|
|
8d63ce |
1 file changed, 8 insertions(+), 1 deletion(-)
|
|
|
8d63ce |
|
|
|
8d63ce |
diff --git a/src/audio/SDL_wave.c b/src/audio/SDL_wave.c
|
|
|
8d63ce |
index b6c49de..2968b3d 100644
|
|
|
8d63ce |
--- a/src/audio/SDL_wave.c
|
|
|
8d63ce |
+++ b/src/audio/SDL_wave.c
|
|
|
8d63ce |
@@ -334,7 +334,7 @@ static void Fill_IMA_ADPCM_block(Uint8 *decoded, Uint8 *encoded,
|
|
|
8d63ce |
static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
{
|
|
|
8d63ce |
struct IMA_ADPCM_decodestate *state;
|
|
|
8d63ce |
- Uint8 *freeable, *encoded, *decoded;
|
|
|
8d63ce |
+ Uint8 *freeable, *encoded, *encoded_end, *decoded;
|
|
|
8d63ce |
Sint32 encoded_len, samplesleft;
|
|
|
8d63ce |
unsigned int c, channels;
|
|
|
8d63ce |
|
|
|
8d63ce |
@@ -350,6 +350,7 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
/* Allocate the proper sized output buffer */
|
|
|
8d63ce |
encoded_len = *audio_len;
|
|
|
8d63ce |
encoded = *audio_buf;
|
|
|
8d63ce |
+ encoded_end = encoded + encoded_len;
|
|
|
8d63ce |
freeable = *audio_buf;
|
|
|
8d63ce |
*audio_len = (encoded_len/IMA_ADPCM_state.wavefmt.blockalign) *
|
|
|
8d63ce |
IMA_ADPCM_state.wSamplesPerBlock*
|
|
|
8d63ce |
@@ -365,6 +366,7 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
while ( encoded_len >= IMA_ADPCM_state.wavefmt.blockalign ) {
|
|
|
8d63ce |
/* Grab the initial information for this block */
|
|
|
8d63ce |
for ( c=0; c
|
|
|
8d63ce |
+ if (encoded + 4 > encoded_end) goto invalid_size;
|
|
|
8d63ce |
/* Fill the state information for this block */
|
|
|
8d63ce |
state[c].sample = ((encoded[1]<<8)|encoded[0]);
|
|
|
8d63ce |
encoded += 2;
|
|
|
8d63ce |
@@ -387,6 +389,7 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
samplesleft = (IMA_ADPCM_state.wSamplesPerBlock-1)*channels;
|
|
|
8d63ce |
while ( samplesleft > 0 ) {
|
|
|
8d63ce |
for ( c=0; c
|
|
|
8d63ce |
+ if (encoded + 4 > encoded_end) goto invalid_size;
|
|
|
8d63ce |
Fill_IMA_ADPCM_block(decoded, encoded,
|
|
|
8d63ce |
c, channels, &state[c]);
|
|
|
8d63ce |
encoded += 4;
|
|
|
8d63ce |
@@ -398,6 +401,10 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
}
|
|
|
8d63ce |
SDL_free(freeable);
|
|
|
8d63ce |
return(0);
|
|
|
8d63ce |
+invalid_size:
|
|
|
8d63ce |
+ SDL_SetError("Unexpected chunk length for an IMA ADPCM decoder");
|
|
|
8d63ce |
+ SDL_free(freeable);
|
|
|
8d63ce |
+ return(-1);
|
|
|
8d63ce |
}
|
|
|
8d63ce |
|
|
|
8d63ce |
SDL_AudioSpec * SDL_LoadWAV_RW (SDL_RWops *src, int freesrc,
|
|
|
8d63ce |
--
|
|
|
8d63ce |
2.20.1
|
|
|
8d63ce |
|