|
 |
8d63ce |
From 6086741bda4d43cc227500bc7645a829380e6326 Mon Sep 17 00:00:00 2001
|
|
|
8d63ce |
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
|
|
|
8d63ce |
Date: Fri, 15 Feb 2019 09:21:45 +0100
|
|
|
8d63ce |
Subject: [PATCH] CVE-2019-7572: Fix a buffer overwrite in IMA_ADPCM_decode
|
|
|
8d63ce |
MIME-Version: 1.0
|
|
|
8d63ce |
Content-Type: text/plain; charset=UTF-8
|
|
|
8d63ce |
Content-Transfer-Encoding: 8bit
|
|
|
8d63ce |
|
|
|
8d63ce |
If data chunk was longer than expected based on a WAV format
|
|
|
8d63ce |
definition, IMA_ADPCM_decode() tried to write past the output
|
|
|
8d63ce |
buffer. This patch fixes it.
|
|
|
8d63ce |
|
|
|
8d63ce |
Based on patch from
|
|
|
8d63ce |
<https://bugzilla.libsdl.org/show_bug.cgi?id=4496>.
|
|
|
8d63ce |
|
|
|
8d63ce |
CVE-2019-7572
|
|
|
8d63ce |
https://bugzilla.libsdl.org/show_bug.cgi?id=4495
|
|
|
8d63ce |
|
|
|
8d63ce |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
8d63ce |
---
|
|
|
8d63ce |
src/audio/SDL_wave.c | 6 +++++-
|
|
|
8d63ce |
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
8d63ce |
|
|
|
8d63ce |
diff --git a/src/audio/SDL_wave.c b/src/audio/SDL_wave.c
|
|
|
8d63ce |
index 69d62dc..91e89e8 100644
|
|
|
8d63ce |
--- a/src/audio/SDL_wave.c
|
|
|
8d63ce |
+++ b/src/audio/SDL_wave.c
|
|
|
8d63ce |
@@ -336,7 +336,7 @@ static void Fill_IMA_ADPCM_block(Uint8 *decoded, Uint8 *encoded,
|
|
|
8d63ce |
static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
{
|
|
|
8d63ce |
struct IMA_ADPCM_decodestate *state;
|
|
|
8d63ce |
- Uint8 *freeable, *encoded, *encoded_end, *decoded;
|
|
|
8d63ce |
+ Uint8 *freeable, *encoded, *encoded_end, *decoded, *decoded_end;
|
|
|
8d63ce |
Sint32 encoded_len, samplesleft;
|
|
|
8d63ce |
unsigned int c, channels;
|
|
|
8d63ce |
|
|
|
8d63ce |
@@ -363,6 +363,7 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
return(-1);
|
|
|
8d63ce |
}
|
|
|
8d63ce |
decoded = *audio_buf;
|
|
|
8d63ce |
+ decoded_end = decoded + *audio_len;
|
|
|
8d63ce |
|
|
|
8d63ce |
/* Get ready... Go! */
|
|
|
8d63ce |
while ( encoded_len >= IMA_ADPCM_state.wavefmt.blockalign ) {
|
|
|
8d63ce |
@@ -382,6 +383,7 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
}
|
|
|
8d63ce |
|
|
|
8d63ce |
/* Store the initial sample we start with */
|
|
|
8d63ce |
+ if (decoded + 2 > decoded_end) goto invalid_size;
|
|
|
8d63ce |
decoded[0] = (Uint8)(state[c].sample&0xFF);
|
|
|
8d63ce |
decoded[1] = (Uint8)(state[c].sample>>8);
|
|
|
8d63ce |
decoded += 2;
|
|
|
8d63ce |
@@ -392,6 +394,8 @@ static int IMA_ADPCM_decode(Uint8 **audio_buf, Uint32 *audio_len)
|
|
|
8d63ce |
while ( samplesleft > 0 ) {
|
|
|
8d63ce |
for ( c=0; c
|
|
|
8d63ce |
if (encoded + 4 > encoded_end) goto invalid_size;
|
|
|
8d63ce |
+ if (decoded + 4 * 4 * channels > decoded_end)
|
|
|
8d63ce |
+ goto invalid_size;
|
|
|
8d63ce |
Fill_IMA_ADPCM_block(decoded, encoded,
|
|
|
8d63ce |
c, channels, &state[c]);
|
|
|
8d63ce |
encoded += 4;
|
|
|
8d63ce |
--
|
|
|
8d63ce |
2.20.1
|
|
|
8d63ce |
|