|
 |
7d68e2 |
From c9c13747e575fe2ce398cec200284d0318aaece3 Mon Sep 17 00:00:00 2001
|
|
|
7d68e2 |
From: Michael Catanzaro <mcatanzaro@gnome.org>
|
|
|
7d68e2 |
Date: Wed, 29 Apr 2020 13:44:41 -0500
|
|
|
7d68e2 |
Subject: [PATCH] Revert "Shutdown the daemon on idle by default"
|
|
|
7d68e2 |
|
|
|
7d68e2 |
This reverts commit 0c84d71509e851db20445c747529bd7d3724f081.
|
|
|
7d68e2 |
|
|
|
7d68e2 |
This broke the end session dialog in GNOME Shell.
|
|
|
7d68e2 |
|
|
|
7d68e2 |
I thought I had that fixed by changing GNOME Shell to autostart
|
|
|
7d68e2 |
PackageKit when it is not already running:
|
|
|
7d68e2 |
|
|
|
7d68e2 |
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1104
|
|
|
7d68e2 |
|
|
|
7d68e2 |
But turns out, there are more problems. The update fails if the user has
|
|
|
7d68e2 |
used dnf since PackageKit last quit, a scenario I did not test. It also
|
|
|
7d68e2 |
results in GNOME Software getting confused about what software is
|
|
|
7d68e2 |
installed and what software is not. The issues are discussed here:
|
|
|
7d68e2 |
|
|
|
7d68e2 |
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1227#note_784327
|
|
|
7d68e2 |
|
|
|
7d68e2 |
It's still desirable to shut down automatically, but it requires more
|
|
|
7d68e2 |
planning. And shutting down GNOME Software itself is frankly more
|
|
|
7d68e2 |
important, since it uses a lot more RAM than packagekitd.
|
|
|
7d68e2 |
---
|
|
|
7d68e2 |
src/pk-main.c | 2 --
|
|
|
7d68e2 |
1 file changed, 2 deletions(-)
|
|
|
7d68e2 |
|
|
|
7d68e2 |
diff --git a/src/pk-main.c b/src/pk-main.c
|
|
|
7d68e2 |
index 7a0bbd199..5791c5fef 100644
|
|
|
7d68e2 |
--- a/src/pk-main.c
|
|
|
7d68e2 |
+++ b/src/pk-main.c
|
|
|
7d68e2 |
@@ -178,8 +178,6 @@ main (int argc, char *argv[])
|
|
|
7d68e2 |
|
|
|
7d68e2 |
/* after how long do we timeout? */
|
|
|
7d68e2 |
exit_idle_time = g_key_file_get_integer (conf, "Daemon", "ShutdownTimeout", NULL);
|
|
|
7d68e2 |
- if (exit_idle_time == 0)
|
|
|
7d68e2 |
- exit_idle_time = 300;
|
|
|
7d68e2 |
g_debug ("daemon shutdown set to %i seconds", exit_idle_time);
|
|
|
7d68e2 |
|
|
|
7d68e2 |
/* override the backend name */
|