|
 |
2e715b |
From 7ba52fdcfeeb1e5400bcecb9fa93b3099dcccb47 Mon Sep 17 00:00:00 2001
|
|
|
2e715b |
From: Beniamino Galvani <bgalvani@redhat.com>
|
|
|
2e715b |
Date: Fri, 25 Feb 2022 10:06:48 +0100
|
|
|
2e715b |
Subject: [PATCH] core: initialize l3cd dns-priority for ppp and wwan
|
|
|
2e715b |
|
|
|
2e715b |
For devices that configure IP by themselves (by returning
|
|
|
2e715b |
"->ready_for_ip_config() = TRUE" and implementing
|
|
|
2e715b |
->act_stage3_ip_config()), we skip manual configuration. Currently,
|
|
|
2e715b |
manual configuration is the only one that sets flag HAS_DNS_PRIORITY
|
|
|
2e715b |
into the resulting l3cd.
|
|
|
2e715b |
|
|
|
2e715b |
So, the merged l3cd for such devices misses a dns-priority and is
|
|
|
2e715b |
ignored by the DNS manager.
|
|
|
2e715b |
|
|
|
2e715b |
Explicitly initialize the priority to 0; in this way, the default
|
|
|
2e715b |
value for the device will be set in the final l3cd during the merge.
|
|
|
2e715b |
|
|
|
2e715b |
Fixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration')
|
|
|
2e715b |
|
|
|
2e715b |
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/931
|
|
|
2e715b |
(cherry picked from commit b2e559fab2fa5adbf4e159fc1c2cadd3d965b01b)
|
|
|
2e715b |
(cherry picked from commit bfd3216584e9fe1eb0b6f3f81e3eb75a40877775)
|
|
|
2e715b |
---
|
|
|
2e715b |
src/core/devices/wwan/nm-modem-broadband.c | 2 ++
|
|
|
2e715b |
src/core/ppp/nm-ppp-manager.c | 1 +
|
|
|
2e715b |
2 files changed, 3 insertions(+)
|
|
|
2e715b |
|
|
|
2e715b |
diff --git a/src/core/devices/wwan/nm-modem-broadband.c b/src/core/devices/wwan/nm-modem-broadband.c
|
|
|
2e715b |
index f5336d3750..b585652e5d 100644
|
|
|
2e715b |
--- a/src/core/devices/wwan/nm-modem-broadband.c
|
|
|
2e715b |
+++ b/src/core/devices/wwan/nm-modem-broadband.c
|
|
|
2e715b |
@@ -1032,6 +1032,7 @@ stage3_ip_config_start(NMModem *modem, int addr_family, NMModemIPMethod ip_metho
|
|
|
2e715b |
l3cd = nm_l3_config_data_new(nm_platform_get_multi_idx(NM_PLATFORM_GET),
|
|
|
2e715b |
ifindex,
|
|
|
2e715b |
NM_IP_CONFIG_SOURCE_WWAN);
|
|
|
2e715b |
+ nm_l3_config_data_set_dns_priority(l3cd, AF_INET, 0);
|
|
|
2e715b |
|
|
|
2e715b |
address = (NMPlatformIP4Address){
|
|
|
2e715b |
.address = address_network,
|
|
|
2e715b |
@@ -1118,6 +1119,7 @@ stage3_ip_config_start(NMModem *modem, int addr_family, NMModemIPMethod ip_metho
|
|
|
2e715b |
l3cd = nm_l3_config_data_new(nm_platform_get_multi_idx(NM_PLATFORM_GET),
|
|
|
2e715b |
ifindex,
|
|
|
2e715b |
NM_IP_CONFIG_SOURCE_WWAN);
|
|
|
2e715b |
+ nm_l3_config_data_set_dns_priority(l3cd, AF_INET6, 0);
|
|
|
2e715b |
|
|
|
2e715b |
do_auto = TRUE;
|
|
|
2e715b |
|
|
|
2e715b |
diff --git a/src/core/ppp/nm-ppp-manager.c b/src/core/ppp/nm-ppp-manager.c
|
|
|
2e715b |
index dd6b1bc7f0..5761d59d39 100644
|
|
|
2e715b |
--- a/src/core/ppp/nm-ppp-manager.c
|
|
|
2e715b |
+++ b/src/core/ppp/nm-ppp-manager.c
|
|
|
2e715b |
@@ -545,6 +545,7 @@ impl_ppp_manager_set_ip4_config(NMDBusObject *obj,
|
|
|
2e715b |
NM_IP_CONFIG_SOURCE_PPP);
|
|
|
2e715b |
|
|
|
2e715b |
nm_l3_config_data_set_mtu(l3cd, mtu);
|
|
|
2e715b |
+ nm_l3_config_data_set_dns_priority(l3cd, AF_INET, 0);
|
|
|
2e715b |
|
|
|
2e715b |
address = (NMPlatformIP4Address){
|
|
|
2e715b |
.plen = 32,
|
|
|
2e715b |
--
|
|
|
2e715b |
2.34.1
|
|
|
2e715b |
|