From a90030205cdd1c640537ddd5353a900291243746 Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: <5575e0aec51f40ebec46e98ec085cda053283aba.1383564115.git.minovotn@redhat.com> References: <5575e0aec51f40ebec46e98ec085cda053283aba.1383564115.git.minovotn@redhat.com> From: Markus Armbruster Date: Fri, 27 Sep 2013 13:31:19 +0200 Subject: [PATCH 09/14] qtest: Don't reset on qtest chardev connect RH-Author: Markus Armbruster Message-id: <1380288680-26645-10-git-send-email-armbru@redhat.com> Patchwork-id: 54565 O-Subject: [PATCH 7.0 qemu-kvm 09/10] qtest: Don't reset on qtest chardev connect Bugzilla: 997817 RH-Acked-by: Paolo Bonzini RH-Acked-by: Laszlo Ersek RH-Acked-by: Luiz Capitulino From: Markus Armbruster libqtest's qtest_init() connecting to the qtest socket triggers reset. This was coded in the hope we could use the same QEMU process for multiple tests that way. Never used. Injects an extra reset even when it's not used, and that can mess up tests such as the one of -boot once I'm about to add. Drop it. Signed-off-by: Markus Armbruster Message-id: 1372254743-15808-2-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori (cherry picked from commit ba646ff6a3149f416424122c628e798be4957997) --- qtest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) Signed-off-by: Michal Novotny --- qtest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qtest.c b/qtest.c index 07a9612..74f1842 100644 --- a/qtest.c +++ b/qtest.c @@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event) switch (event) { case CHR_EVENT_OPENED: - qemu_system_reset(false); + /* + * We used to call qemu_system_reset() here, hoping we could + * use the same process for multiple tests that way. Never + * used. Injects an extra reset even when it's not used, and + * that can mess up tests, e.g. -boot once. + */ for (i = 0; i < ARRAY_SIZE(irq_levels); i++) { irq_levels[i] = 0; } -- 1.7.11.7