From a2befb24c10f58ce6c27d242f3b88afee1f77ec8 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Tue, 7 Jul 2020 09:35:31 -0400 Subject: [PATCH 2/4] s390x: sigp: Fix sense running reporting RH-Author: Thomas Huth Message-id: <20200707093532.22456-2-thuth@redhat.com> Patchwork-id: 97920 O-Subject: [RHEL-8.3.0 qemu-kvm PATCH 1/2] s390x: sigp: Fix sense running reporting Bugzilla: 1854092 RH-Acked-by: Jens Freimann RH-Acked-by: Cornelia Huck RH-Acked-by: David Hildenbrand From: Janosch Frank The logic was inverted and reported running if the cpu was stopped. Let's fix that. Signed-off-by: Janosch Frank Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS") Reviewed-by: David Hildenbrand Message-Id: <20200124134818.9981-1-frankja@linux.ibm.com> Signed-off-by: Cornelia Huck (cherry picked from commit 4103500e2fa934a6995e4cedab37423e606715bf) Signed-off-by: Danilo C. L. de Paula --- target/s390x/sigp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c index 727875bb4a..c604f17710 100644 --- a/target/s390x/sigp.c +++ b/target/s390x/sigp.c @@ -348,9 +348,9 @@ static void sigp_sense_running(S390CPU *dst_cpu, SigpInfo *si) /* If halted (which includes also STOPPED), it is not running */ if (CPU(dst_cpu)->halted) { - si->cc = SIGP_CC_ORDER_CODE_ACCEPTED; - } else { set_sigp_status(si, SIGP_STAT_NOT_RUNNING); + } else { + si->cc = SIGP_CC_ORDER_CODE_ACCEPTED; } } -- 2.27.0