From 5bf64f8c7302964bd5fd208d9db9fa38ee96e0fa Mon Sep 17 00:00:00 2001 From: Alex Williamson Date: Fri, 10 Apr 2015 16:33:39 +0200 Subject: [PATCH 01/14] vfio: warn if host device rom can't be read Message-id: <20150410163339.15324.77513.stgit@gimli.home> Patchwork-id: 64789 O-Subject: [RHEL7.2 qemu-kvm PATCH 1/8] vfio: warn if host device rom can't be read Bugzilla: 1210503 RH-Acked-by: Thomas Huth RH-Acked-by: Laszlo Ersek RH-Acked-by: Bandan Das From: Bandan Das Upstream: d20b43dfea1587b561aae17e4fa0f7407779d253 If the device rom can't be read, report an error to the user. This alerts the user that the device has a bad state that is causing rom read failure or option rom loading has been disabled from the device boot menu (among other reasons). Signed-off-by: Bandan Das Signed-off-by: Alex Williamson Signed-off-by: Miroslav Rezanina --- hw/misc/vfio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 40b0923..c9dbc28 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -1197,6 +1197,13 @@ static void vfio_pci_load_rom(VFIODevice *vdev) vdev->rom_offset = reg_info.offset; if (!vdev->rom_size) { + error_report("vfio-pci: Cannot read device rom at " + "%04x:%02x:%02x.%x\n", + vdev->host.domain, vdev->host.bus, vdev->host.slot, + vdev->host.function); + error_printf("Device option ROM contents are probably invalid " + "(check dmesg).\nSkip option ROM probe with rombar=0, " + "or load from file with romfile=\n"); return; } -- 1.8.3.1