|
 |
9ae3a8 |
From c5ee3f3aab59ff26b0fed770077a16714da9696e Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
9ae3a8 |
Date: Thu, 28 Apr 2016 16:07:27 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 22/27] vga: Remove some "should be done in BIOS" comments
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1461859652-20918-2-git-send-email-kraxel@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 70292
|
|
|
9ae3a8 |
O-Subject: [virt-devel] [RHEL-7.3 qemu-kvm PATCH 1/6] vga: Remove some "should be done in BIOS" comments
|
|
|
9ae3a8 |
Bugzilla: 1331413
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Not all platforms have a VGA BIOS, powerpc typically relies on
|
|
|
9ae3a8 |
using the DISPI interface to initialize the card.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
|
|
|
9ae3a8 |
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
|
|
|
9ae3a8 |
(cherry picked from commit ace89b8ff21cc3fb20986a334e54e6e6a1ccf729)
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/display/vga.c | 6 ++----
|
|
|
9ae3a8 |
1 file changed, 2 insertions(+), 4 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/display/vga.c b/hw/display/vga.c
|
|
|
9ae3a8 |
index 0761b9e..48dad03 100644
|
|
|
9ae3a8 |
--- a/hw/display/vga.c
|
|
|
9ae3a8 |
+++ b/hw/display/vga.c
|
|
|
9ae3a8 |
@@ -764,14 +764,13 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
|
|
|
9ae3a8 |
s->vbe_regs[VBE_DISPI_INDEX_ENABLE] |= VBE_DISPI_ENABLED;
|
|
|
9ae3a8 |
vbe_fixup_regs(s);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- /* clear the screen (should be done in BIOS) */
|
|
|
9ae3a8 |
+ /* clear the screen */
|
|
|
9ae3a8 |
if (!(val & VBE_DISPI_NOCLEARMEM)) {
|
|
|
9ae3a8 |
memset(s->vram_ptr, 0,
|
|
|
9ae3a8 |
s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- /* we initialize the VGA graphic mode (should be done
|
|
|
9ae3a8 |
- in BIOS) */
|
|
|
9ae3a8 |
+ /* we initialize the VGA graphic mode */
|
|
|
9ae3a8 |
/* graphic mode + memory map 1 */
|
|
|
9ae3a8 |
s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 |
|
|
|
9ae3a8 |
VGA_GR06_GRAPHICS_MODE;
|
|
|
9ae3a8 |
@@ -804,7 +803,6 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
|
|
|
9ae3a8 |
(shift_control << 5);
|
|
|
9ae3a8 |
s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
- /* XXX: the bios should do that */
|
|
|
9ae3a8 |
s->bank_offset = 0;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0;
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|