|
 |
9ae3a8 |
From f51c618ce3598d9a6a3256e4dd2b9dd3164fbc81 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Date: Thu, 23 Feb 2017 14:29:36 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 06/17] target-i386: kvm_cpu_fill_host(): No need to check
|
|
|
9ae3a8 |
xlevel2
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Message-id: <20170223142945.17790-6-ehabkost@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 74036
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.4 qemu-kvm PATCH v2 05/14] target-i386: kvm_cpu_fill_host(): No need to check xlevel2
|
|
|
9ae3a8 |
Bugzilla: 1382122
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Igor Mammedov <imammedo@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
There's no need to check CPU xlevel2 before calling
|
|
|
9ae3a8 |
kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX), because:
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* The kernel won't return any entry for 0xC0000000 if host CPU vendor
|
|
|
9ae3a8 |
is not Centaur (See kvm_dev_ioctl_get_supported_cpuid() on the kernel
|
|
|
9ae3a8 |
code)
|
|
|
9ae3a8 |
* Similarly, the kernel won't return any entry for 0xC0000001 if
|
|
|
9ae3a8 |
CPUID[0xC0000000].EAX is < 0xC0000001
|
|
|
9ae3a8 |
* kvm_arch_get_supported_cpuid() will return 0 if no entry is returned
|
|
|
9ae3a8 |
by the kernel for the requested leaf
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
For similar reasons, we can simply set x86_cpu_def->xlevel2 directly
|
|
|
9ae3a8 |
instead of making it conditional, because it will be set to 0 CPU vendor
|
|
|
9ae3a8 |
is not Centaur.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
This will simplify the kvm_cpu_fill_host() code a little.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
[Remove unparseable comment. - Paolo]
|
|
|
9ae3a8 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit 803a932706e3ba335d4c98f3577a05cb000f1699)
|
|
|
9ae3a8 |
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
target-i386/cpu.c | 11 ++++-------
|
|
|
9ae3a8 |
1 file changed, 4 insertions(+), 7 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
|
|
|
9ae3a8 |
index a10055b..02bd038 100644
|
|
|
9ae3a8 |
--- a/target-i386/cpu.c
|
|
|
9ae3a8 |
+++ b/target-i386/cpu.c
|
|
|
9ae3a8 |
@@ -1285,13 +1285,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
|
|
|
9ae3a8 |
cpu_x86_fill_model_id(x86_cpu_def->model_id);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/* Call Centaur's CPUID instruction. */
|
|
|
9ae3a8 |
- eax = kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX);
|
|
|
9ae3a8 |
- if (eax >= 0xC0000001) {
|
|
|
9ae3a8 |
- /* Support VIA max extended level */
|
|
|
9ae3a8 |
- x86_cpu_def->xlevel2 = eax;
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_C000_0001_EDX] =
|
|
|
9ae3a8 |
- kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX);
|
|
|
9ae3a8 |
- }
|
|
|
9ae3a8 |
+ x86_cpu_def->xlevel2 =
|
|
|
9ae3a8 |
+ kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX);
|
|
|
9ae3a8 |
+ x86_cpu_def->features[FEAT_C000_0001_EDX] =
|
|
|
9ae3a8 |
+ kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/* Other KVM-specific feature fields: */
|
|
|
9ae3a8 |
x86_cpu_def->features[FEAT_SVM] =
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|