|
 |
9ae3a8 |
From 40d8624f4a90769b60ee567035f8231b64c10011 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Date: Thu, 23 Feb 2017 14:29:34 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 04/17] target-i386: kvm_cpu_fill_host(): No need to check
|
|
|
9ae3a8 |
level
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Message-id: <20170223142945.17790-4-ehabkost@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 74035
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.4 qemu-kvm PATCH v2 03/14] target-i386: kvm_cpu_fill_host(): No need to check level
|
|
|
9ae3a8 |
Bugzilla: 1382122
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Igor Mammedov <imammedo@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
There's no need to check level (CPUID[0].EAX) before calling
|
|
|
9ae3a8 |
kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EBX), because:
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* The kernel won't return any entry for CPUID 7 if CPUID[0].EAX is < 7
|
|
|
9ae3a8 |
on the host (See kvm_dev_ioctl_get_cpuid() on the kernel code);
|
|
|
9ae3a8 |
* kvm_arch_get_supported_cpuid() will return 0 if no entry is returned
|
|
|
9ae3a8 |
by the kernel for the requested leaf.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
This will simplify the kvm_cpu_fill_host() code a little.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit 7171a3933f2ee8cb984fd64c59ca081f39b943a4)
|
|
|
9ae3a8 |
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
target-i386/cpu.c | 18 ++++++------------
|
|
|
9ae3a8 |
1 file changed, 6 insertions(+), 12 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
|
|
|
9ae3a8 |
index 8a49ff5..c82073e 100644
|
|
|
9ae3a8 |
--- a/target-i386/cpu.c
|
|
|
9ae3a8 |
+++ b/target-i386/cpu.c
|
|
|
9ae3a8 |
@@ -1267,18 +1267,12 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
|
|
|
9ae3a8 |
x86_cpu_def->features[FEAT_1_ECX] =
|
|
|
9ae3a8 |
kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- if (x86_cpu_def->level >= 7) {
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_EBX] =
|
|
|
9ae3a8 |
- kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EBX);
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_ECX] =
|
|
|
9ae3a8 |
- kvm_arch_get_supported_cpuid(s, 0x7, 0, R_ECX);
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_EDX] =
|
|
|
9ae3a8 |
- kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EDX);
|
|
|
9ae3a8 |
- } else {
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_EBX] = 0;
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_ECX] = 0;
|
|
|
9ae3a8 |
- x86_cpu_def->features[FEAT_7_0_EDX] = 0;
|
|
|
9ae3a8 |
- }
|
|
|
9ae3a8 |
+ x86_cpu_def->features[FEAT_7_0_EBX] =
|
|
|
9ae3a8 |
+ kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EBX);
|
|
|
9ae3a8 |
+ x86_cpu_def->features[FEAT_7_0_ECX] =
|
|
|
9ae3a8 |
+ kvm_arch_get_supported_cpuid(s, 0x7, 0, R_ECX);
|
|
|
9ae3a8 |
+ x86_cpu_def->features[FEAT_7_0_EDX] =
|
|
|
9ae3a8 |
+ kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EDX);
|
|
|
9ae3a8 |
x86_cpu_def->features[FEAT_XSAVE] =
|
|
|
9ae3a8 |
kvm_arch_get_supported_cpuid(s, 0xd, 1, R_EAX);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|