yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
22c213
From 4009f0bcc8004ce481015d088fe335a16b8d7ce1 Mon Sep 17 00:00:00 2001
22c213
From: Paolo Bonzini <pbonzini@redhat.com>
22c213
Date: Mon, 17 Feb 2020 16:23:12 +0000
22c213
Subject: [PATCH 2/9] target/i386: add a ucode-rev property
22c213
22c213
RH-Author: Paolo Bonzini <pbonzini@redhat.com>
22c213
Message-id: <20200217162316.2464-3-pbonzini@redhat.com>
22c213
Patchwork-id: 93909
22c213
O-Subject: [RHEL-AV-8.2.0 qemu-kvm PATCH 2/6] target/i386: add a ucode-rev property
22c213
Bugzilla: 1791648
22c213
RH-Acked-by: Eduardo Habkost <ehabkost@redhat.com>
22c213
RH-Acked-by: Maxim Levitsky <mlevitsk@redhat.com>
22c213
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
22c213
22c213
Add the property and plumb it in TCG and HVF (the latter of which
22c213
tried to support returning a constant value but used the wrong MSR).
22c213
22c213
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
22c213
Message-Id: <1579544504-3616-3-git-send-email-pbonzini@redhat.com>
22c213
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
22c213
(cherry picked from commit 4e45aff398cd1542c2a384a2a3b8600f23337d86)
22c213
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
22c213
---
22c213
 target/i386/cpu.c         | 10 ++++++++++
22c213
 target/i386/cpu.h         |  3 +++
22c213
 target/i386/hvf/x86_emu.c |  4 +---
22c213
 target/i386/misc_helper.c |  4 ++++
22c213
 4 files changed, 18 insertions(+), 3 deletions(-)
22c213
22c213
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
22c213
index 863192c..e505d3e 100644
22c213
--- a/target/i386/cpu.c
22c213
+++ b/target/i386/cpu.c
22c213
@@ -6325,6 +6325,15 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
22c213
         }
22c213
     }
22c213
 
22c213
+    if (cpu->ucode_rev == 0) {
22c213
+        /* The default is the same as KVM's.  */
22c213
+        if (IS_AMD_CPU(env)) {
22c213
+            cpu->ucode_rev = 0x01000065;
22c213
+        } else {
22c213
+            cpu->ucode_rev = 0x100000000ULL;
22c213
+        }
22c213
+    }
22c213
+
22c213
     /* mwait extended info: needed for Core compatibility */
22c213
     /* We always wake on interrupt even if host does not have the capability */
22c213
     cpu->mwait.ecx |= CPUID_MWAIT_EMX | CPUID_MWAIT_IBE;
22c213
@@ -7008,6 +7017,7 @@ static Property x86_cpu_properties[] = {
22c213
     DEFINE_PROP_UINT32("min-level", X86CPU, env.cpuid_min_level, 0),
22c213
     DEFINE_PROP_UINT32("min-xlevel", X86CPU, env.cpuid_min_xlevel, 0),
22c213
     DEFINE_PROP_UINT32("min-xlevel2", X86CPU, env.cpuid_min_xlevel2, 0),
22c213
+    DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0),
22c213
     DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_level, true),
22c213
     DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor_id),
22c213
     DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
22c213
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
22c213
index cde2a16..4441061 100644
22c213
--- a/target/i386/cpu.h
22c213
+++ b/target/i386/cpu.h
22c213
@@ -348,6 +348,7 @@ typedef enum X86Seg {
22c213
 #define MSR_IA32_SPEC_CTRL              0x48
22c213
 #define MSR_VIRT_SSBD                   0xc001011f
22c213
 #define MSR_IA32_PRED_CMD               0x49
22c213
+#define MSR_IA32_UCODE_REV              0x8b
22c213
 #define MSR_IA32_CORE_CAPABILITY        0xcf
22c213
 
22c213
 #define MSR_IA32_ARCH_CAPABILITIES      0x10a
22c213
@@ -1621,6 +1622,8 @@ struct X86CPU {
22c213
     CPUNegativeOffsetState neg;
22c213
     CPUX86State env;
22c213
 
22c213
+    uint64_t ucode_rev;
22c213
+
22c213
     uint32_t hyperv_spinlock_attempts;
22c213
     char *hyperv_vendor_id;
22c213
     bool hyperv_synic_kvm_only;
22c213
diff --git a/target/i386/hvf/x86_emu.c b/target/i386/hvf/x86_emu.c
22c213
index 3df7672..92ab815 100644
22c213
--- a/target/i386/hvf/x86_emu.c
22c213
+++ b/target/i386/hvf/x86_emu.c
22c213
@@ -664,8 +664,6 @@ static void exec_lods(struct CPUX86State *env, struct x86_decode *decode)
22c213
     RIP(env) += decode->len;
22c213
 }
22c213
 
22c213
-#define MSR_IA32_UCODE_REV 0x00000017
22c213
-
22c213
 void simulate_rdmsr(struct CPUState *cpu)
22c213
 {
22c213
     X86CPU *x86_cpu = X86_CPU(cpu);
22c213
@@ -681,7 +679,7 @@ void simulate_rdmsr(struct CPUState *cpu)
22c213
         val = cpu_get_apic_base(X86_CPU(cpu)->apic_state);
22c213
         break;
22c213
     case MSR_IA32_UCODE_REV:
22c213
-        val = (0x100000000ULL << 32) | 0x100000000ULL;
22c213
+        val = x86_cpu->ucode_rev;
22c213
         break;
22c213
     case MSR_EFER:
22c213
         val = rvmcs(cpu->hvf_fd, VMCS_GUEST_IA32_EFER);
22c213
diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c
22c213
index 3eff688..aed16fe 100644
22c213
--- a/target/i386/misc_helper.c
22c213
+++ b/target/i386/misc_helper.c
22c213
@@ -229,6 +229,7 @@ void helper_rdmsr(CPUX86State *env)
22c213
 #else
22c213
 void helper_wrmsr(CPUX86State *env)
22c213
 {
22c213
+    X86CPU *x86_cpu = env_archcpu(env);
22c213
     uint64_t val;
22c213
 
22c213
     cpu_svm_check_intercept_param(env, SVM_EXIT_MSR, 1, GETPC());
22c213
@@ -371,6 +372,9 @@ void helper_wrmsr(CPUX86State *env)
22c213
         env->msr_bndcfgs = val;
22c213
         cpu_sync_bndcs_hflags(env);
22c213
         break;
22c213
+     case MSR_IA32_UCODE_REV:
22c213
+        val = x86_cpu->ucode_rev;
22c213
+        break;
22c213
     default:
22c213
         if ((uint32_t)env->regs[R_ECX] >= MSR_MC0_CTL
22c213
             && (uint32_t)env->regs[R_ECX] < MSR_MC0_CTL +
22c213
-- 
22c213
1.8.3.1
22c213