yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone

Blame SOURCES/kvm-spapr_pci-Remove-unhelpful-pagesize-warning.patch

26ba25
From 7cce70900ecb644004144c999ee082ff79c0c25e Mon Sep 17 00:00:00 2001
26ba25
From: David Gibson <dgibson@redhat.com>
26ba25
Date: Thu, 14 Jun 2018 01:31:36 +0200
26ba25
Subject: [PATCH 008/268] spapr_pci: Remove unhelpful pagesize warning
26ba25
26ba25
RH-Author: David Gibson <dgibson@redhat.com>
26ba25
Message-id: <20180614013136.3504-1-dgibson@redhat.com>
26ba25
Patchwork-id: 80681
26ba25
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH] spapr_pci: Remove unhelpful pagesize warning
26ba25
Bugzilla: 1505664
26ba25
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
26ba25
RH-Acked-by: Thomas Huth <thuth@redhat.com>
26ba25
RH-Acked-by: Serhii Popovych <spopovyc@redhat.com>
26ba25
26ba25
From: David Gibson <david@gibson.dropbear.id.au>
26ba25
26ba25
By default, the IOMMU model built into the spapr virtual PCI host bridge
26ba25
supports 4kiB and 64kiB IOMMU page sizes.  However this can be overridden
26ba25
which may be desirable to allow larger IOMMU page sizes when running a
26ba25
guest with hugepage backing and passthrough devices.  For that reason a
26ba25
warning was printed when the device wasn't configured to allow the pagesize
26ba25
with which guest RAM is backed.
26ba25
26ba25
Experience has proven, however, that this message is more confusing than
26ba25
useful.  Worse it sometimes makes little sense when the host-available page
26ba25
sizes don't match those available on the guest, which can happen with
26ba25
a POWER8 guest running on a POWER9 KVM host.
26ba25
26ba25
Long term we do want better handling to allow large IOMMU page sizes to be
26ba25
used, but for now this parameter and warning don't really accomplish it.
26ba25
So, remove the message, pending a better solution.
26ba25
26ba25
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
26ba25
26ba25
Signed-off-by: David Gibson <dgibson@redhat.com>
26ba25
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
26ba25
---
26ba25
 hw/ppc/spapr_pci.c | 7 -------
26ba25
 1 file changed, 7 deletions(-)
26ba25
26ba25
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
26ba25
index 39a1498..f936ce6 100644
26ba25
--- a/hw/ppc/spapr_pci.c
26ba25
+++ b/hw/ppc/spapr_pci.c
26ba25
@@ -1717,13 +1717,6 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
26ba25
     }
26ba25
 
26ba25
     /* DMA setup */
26ba25
-    if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
26ba25
-        && kvm_enabled()) {
26ba25
-        warn_report("System page size 0x%lx is not enabled in page_size_mask "
26ba25
-                    "(0x%"PRIx64"). Performance may be slow",
26ba25
-                    qemu_getrampagesize(), sphb->page_size_mask);
26ba25
-    }
26ba25
-
26ba25
     for (i = 0; i < windows_supported; ++i) {
26ba25
         tcet = spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn[i]);
26ba25
         if (!tcet) {
26ba25
-- 
26ba25
1.8.3.1
26ba25