yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone

Blame SOURCES/kvm-spapr_pci-Remove-unhelpful-pagesize-warning.patch

ae23c9
From 7cce70900ecb644004144c999ee082ff79c0c25e Mon Sep 17 00:00:00 2001
ae23c9
From: David Gibson <dgibson@redhat.com>
ae23c9
Date: Thu, 14 Jun 2018 01:31:36 +0200
ae23c9
Subject: [PATCH 008/268] spapr_pci: Remove unhelpful pagesize warning
ae23c9
ae23c9
RH-Author: David Gibson <dgibson@redhat.com>
ae23c9
Message-id: <20180614013136.3504-1-dgibson@redhat.com>
ae23c9
Patchwork-id: 80681
ae23c9
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH] spapr_pci: Remove unhelpful pagesize warning
ae23c9
Bugzilla: 1505664
ae23c9
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
ae23c9
RH-Acked-by: Thomas Huth <thuth@redhat.com>
ae23c9
RH-Acked-by: Serhii Popovych <spopovyc@redhat.com>
ae23c9
ae23c9
From: David Gibson <david@gibson.dropbear.id.au>
ae23c9
ae23c9
By default, the IOMMU model built into the spapr virtual PCI host bridge
ae23c9
supports 4kiB and 64kiB IOMMU page sizes.  However this can be overridden
ae23c9
which may be desirable to allow larger IOMMU page sizes when running a
ae23c9
guest with hugepage backing and passthrough devices.  For that reason a
ae23c9
warning was printed when the device wasn't configured to allow the pagesize
ae23c9
with which guest RAM is backed.
ae23c9
ae23c9
Experience has proven, however, that this message is more confusing than
ae23c9
useful.  Worse it sometimes makes little sense when the host-available page
ae23c9
sizes don't match those available on the guest, which can happen with
ae23c9
a POWER8 guest running on a POWER9 KVM host.
ae23c9
ae23c9
Long term we do want better handling to allow large IOMMU page sizes to be
ae23c9
used, but for now this parameter and warning don't really accomplish it.
ae23c9
So, remove the message, pending a better solution.
ae23c9
ae23c9
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
ae23c9
ae23c9
Signed-off-by: David Gibson <dgibson@redhat.com>
ae23c9
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
ae23c9
---
ae23c9
 hw/ppc/spapr_pci.c | 7 -------
ae23c9
 1 file changed, 7 deletions(-)
ae23c9
ae23c9
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
ae23c9
index 39a1498..f936ce6 100644
ae23c9
--- a/hw/ppc/spapr_pci.c
ae23c9
+++ b/hw/ppc/spapr_pci.c
ae23c9
@@ -1717,13 +1717,6 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
ae23c9
     }
ae23c9
 
ae23c9
     /* DMA setup */
ae23c9
-    if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
ae23c9
-        && kvm_enabled()) {
ae23c9
-        warn_report("System page size 0x%lx is not enabled in page_size_mask "
ae23c9
-                    "(0x%"PRIx64"). Performance may be slow",
ae23c9
-                    qemu_getrampagesize(), sphb->page_size_mask);
ae23c9
-    }
ae23c9
-
ae23c9
     for (i = 0; i < windows_supported; ++i) {
ae23c9
         tcet = spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn[i]);
ae23c9
         if (!tcet) {
ae23c9
-- 
ae23c9
1.8.3.1
ae23c9