yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
26ba25
From 7da8c6f20d4838285af004884666c18f16fb331e Mon Sep 17 00:00:00 2001
26ba25
From: Xiao Wang <jasowang@redhat.com>
26ba25
Date: Fri, 11 Jan 2019 07:58:58 +0000
26ba25
Subject: [PATCH 03/11] pcnet: fix possible buffer overflow
26ba25
MIME-Version: 1.0
26ba25
Content-Type: text/plain; charset=UTF-8
26ba25
Content-Transfer-Encoding: 8bit
26ba25
26ba25
RH-Author: Xiao Wang <jasowang@redhat.com>
26ba25
Message-id: <20190111075904.2030-4-jasowang@redhat.com>
26ba25
Patchwork-id: 83977
26ba25
O-Subject: [RHEL8 qemu-kvm PATCH 3/9] pcnet: fix possible buffer overflow
26ba25
Bugzilla: 1636784
26ba25
RH-Acked-by: Thomas Huth <thuth@redhat.com>
26ba25
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
26ba25
RH-Acked-by: Jens Freimann <jfreimann@redhat.com>
26ba25
RH-Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
26ba25
RH-Acked-by: Michael S. Tsirkin <mst@redhat.com>
26ba25
26ba25
In pcnet_receive(), we try to assign size_ to size which converts from
26ba25
size_t to integer. This will cause troubles when size_ is greater
26ba25
INT_MAX, this will lead a negative value in size and it can then pass
26ba25
the check of size < MIN_BUF_SIZE which may lead out of bound access
26ba25
for both buf and buf1.
26ba25
26ba25
Fixing by converting the type of size to size_t.
26ba25
26ba25
CC: qemu-stable@nongnu.org
26ba25
Reported-by: Daniel Shapira <daniel@twistlock.com>
26ba25
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
26ba25
Signed-off-by: Jason Wang <jasowang@redhat.com>
26ba25
(cherry picked from commit b1d80d12c5f7ff081bb80ab4f4241d4248691192)
26ba25
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
26ba25
---
26ba25
 hw/net/pcnet.c | 4 ++--
26ba25
 1 file changed, 2 insertions(+), 2 deletions(-)
26ba25
26ba25
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
26ba25
index 0c44554..d9ba04b 100644
26ba25
--- a/hw/net/pcnet.c
26ba25
+++ b/hw/net/pcnet.c
26ba25
@@ -988,14 +988,14 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
26ba25
     uint8_t buf1[60];
26ba25
     int remaining;
26ba25
     int crc_err = 0;
26ba25
-    int size = size_;
26ba25
+    size_t size = size_;
26ba25
 
26ba25
     if (CSR_DRX(s) || CSR_STOP(s) || CSR_SPND(s) || !size ||
26ba25
         (CSR_LOOP(s) && !s->looptest)) {
26ba25
         return -1;
26ba25
     }
26ba25
 #ifdef PCNET_DEBUG
26ba25
-    printf("pcnet_receive size=%d\n", size);
26ba25
+    printf("pcnet_receive size=%zu\n", size);
26ba25
 #endif
26ba25
 
26ba25
     /* if too small buffer, then expand it */
26ba25
-- 
26ba25
1.8.3.1
26ba25