yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
ae23c9
From 7da8c6f20d4838285af004884666c18f16fb331e Mon Sep 17 00:00:00 2001
ae23c9
From: Xiao Wang <jasowang@redhat.com>
ae23c9
Date: Fri, 11 Jan 2019 07:58:58 +0000
ae23c9
Subject: [PATCH 03/11] pcnet: fix possible buffer overflow
ae23c9
MIME-Version: 1.0
ae23c9
Content-Type: text/plain; charset=UTF-8
ae23c9
Content-Transfer-Encoding: 8bit
ae23c9
ae23c9
RH-Author: Xiao Wang <jasowang@redhat.com>
ae23c9
Message-id: <20190111075904.2030-4-jasowang@redhat.com>
ae23c9
Patchwork-id: 83977
ae23c9
O-Subject: [RHEL8 qemu-kvm PATCH 3/9] pcnet: fix possible buffer overflow
ae23c9
Bugzilla: 1636784
ae23c9
RH-Acked-by: Thomas Huth <thuth@redhat.com>
ae23c9
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
ae23c9
RH-Acked-by: Jens Freimann <jfreimann@redhat.com>
ae23c9
RH-Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
ae23c9
RH-Acked-by: Michael S. Tsirkin <mst@redhat.com>
ae23c9
ae23c9
In pcnet_receive(), we try to assign size_ to size which converts from
ae23c9
size_t to integer. This will cause troubles when size_ is greater
ae23c9
INT_MAX, this will lead a negative value in size and it can then pass
ae23c9
the check of size < MIN_BUF_SIZE which may lead out of bound access
ae23c9
for both buf and buf1.
ae23c9
ae23c9
Fixing by converting the type of size to size_t.
ae23c9
ae23c9
CC: qemu-stable@nongnu.org
ae23c9
Reported-by: Daniel Shapira <daniel@twistlock.com>
ae23c9
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
ae23c9
Signed-off-by: Jason Wang <jasowang@redhat.com>
ae23c9
(cherry picked from commit b1d80d12c5f7ff081bb80ab4f4241d4248691192)
ae23c9
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
ae23c9
---
ae23c9
 hw/net/pcnet.c | 4 ++--
ae23c9
 1 file changed, 2 insertions(+), 2 deletions(-)
ae23c9
ae23c9
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
ae23c9
index 0c44554..d9ba04b 100644
ae23c9
--- a/hw/net/pcnet.c
ae23c9
+++ b/hw/net/pcnet.c
ae23c9
@@ -988,14 +988,14 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
ae23c9
     uint8_t buf1[60];
ae23c9
     int remaining;
ae23c9
     int crc_err = 0;
ae23c9
-    int size = size_;
ae23c9
+    size_t size = size_;
ae23c9
 
ae23c9
     if (CSR_DRX(s) || CSR_STOP(s) || CSR_SPND(s) || !size ||
ae23c9
         (CSR_LOOP(s) && !s->looptest)) {
ae23c9
         return -1;
ae23c9
     }
ae23c9
 #ifdef PCNET_DEBUG
ae23c9
-    printf("pcnet_receive size=%d\n", size);
ae23c9
+    printf("pcnet_receive size=%zu\n", size);
ae23c9
 #endif
ae23c9
 
ae23c9
     /* if too small buffer, then expand it */
ae23c9
-- 
ae23c9
1.8.3.1
ae23c9