|
 |
ddf19c |
From 7f664fe26ff67f8131faa7a81a388b8a5b51403f Mon Sep 17 00:00:00 2001
|
|
|
ddf19c |
From: Juan Quintela <quintela@redhat.com>
|
|
|
ddf19c |
Date: Tue, 3 Mar 2020 14:51:36 +0000
|
|
|
ddf19c |
Subject: [PATCH 04/18] migration/multifd: fix nullptr access in terminating
|
|
|
ddf19c |
multifd threads
|
|
|
ddf19c |
|
|
|
ddf19c |
RH-Author: Juan Quintela <quintela@redhat.com>
|
|
|
ddf19c |
Message-id: <20200303145143.149290-4-quintela@redhat.com>
|
|
|
ddf19c |
Patchwork-id: 94110
|
|
|
ddf19c |
O-Subject: [RHEL-AV-8.2.0 qemu-kvm PATCH v2 03/10] migration/multifd: fix nullptr access in terminating multifd threads
|
|
|
ddf19c |
Bugzilla: 1738451
|
|
|
ddf19c |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
ddf19c |
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
|
|
ddf19c |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
ddf19c |
|
|
|
ddf19c |
From: Jiahui Cen <cenjiahui@huawei.com>
|
|
|
ddf19c |
|
|
|
ddf19c |
One multifd channel will shutdown all the other multifd's IOChannel when it
|
|
|
ddf19c |
fails to receive an IOChannel. In this senario, if some multifds had not
|
|
|
ddf19c |
received its IOChannel yet, it would try to shutdown its IOChannel which could
|
|
|
ddf19c |
cause nullptr access at qio_channel_shutdown.
|
|
|
ddf19c |
|
|
|
ddf19c |
Here is the coredump stack:
|
|
|
ddf19c |
#0 object_get_class (obj=obj@entry=0x0) at qom/object.c:908
|
|
|
ddf19c |
#1 0x00005563fdbb8f4a in qio_channel_shutdown (ioc=0x0, how=QIO_CHANNEL_SHUTDOWN_BOTH, errp=0x0) at io/channel.c:355
|
|
|
ddf19c |
#2 0x00005563fd7b4c5f in multifd_recv_terminate_threads (err=<optimized out>) at migration/ram.c:1280
|
|
|
ddf19c |
#3 0x00005563fd7bc019 in multifd_recv_new_channel (ioc=ioc@entry=0x556400255610, errp=errp@entry=0x7ffec07dce00) at migration/ram.c:1478
|
|
|
ddf19c |
#4 0x00005563fda82177 in migration_ioc_process_incoming (ioc=ioc@entry=0x556400255610, errp=errp@entry=0x7ffec07dce30) at migration/migration.c:605
|
|
|
ddf19c |
#5 0x00005563fda8567d in migration_channel_process_incoming (ioc=0x556400255610) at migration/channel.c:44
|
|
|
ddf19c |
#6 0x00005563fda83ee0 in socket_accept_incoming_migration (listener=0x5563fff6b920, cioc=0x556400255610, opaque=<optimized out>) at migration/socket.c:166
|
|
|
ddf19c |
#7 0x00005563fdbc25cd in qio_net_listener_channel_func (ioc=<optimized out>, condition=<optimized out>, opaque=<optimized out>) at io/net-listener.c:54
|
|
|
ddf19c |
#8 0x00007f895b6fe9a9 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
|
|
|
ddf19c |
#9 0x00005563fdc18136 in glib_pollfds_poll () at util/main-loop.c:218
|
|
|
ddf19c |
#10 0x00005563fdc181b5 in os_host_main_loop_wait (timeout=1000000000) at util/main-loop.c:241
|
|
|
ddf19c |
#11 0x00005563fdc183a2 in main_loop_wait (nonblocking=nonblocking@entry=0) at util/main-loop.c:517
|
|
|
ddf19c |
#12 0x00005563fd8edb37 in main_loop () at vl.c:1791
|
|
|
ddf19c |
#13 0x00005563fd74fd45 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at vl.c:4473
|
|
|
ddf19c |
|
|
|
ddf19c |
To fix it up, let's check p->c before calling qio_channel_shutdown.
|
|
|
ddf19c |
|
|
|
ddf19c |
Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
|
|
|
ddf19c |
Signed-off-by: Ying Fang <fangying1@huawei.com>
|
|
|
ddf19c |
Reviewed-by: Juan Quintela <quintela@redhat.com>
|
|
|
ddf19c |
Signed-off-by: Juan Quintela <quintela@redhat.com>
|
|
|
ddf19c |
(cherry picked from commit f76e32eb05041ab001184ab16afb56524adccd0c)
|
|
|
ddf19c |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
ddf19c |
---
|
|
|
ddf19c |
migration/ram.c | 4 +++-
|
|
|
ddf19c |
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
ddf19c |
|
|
|
ddf19c |
diff --git a/migration/ram.c b/migration/ram.c
|
|
|
ddf19c |
index 8c783b3..860f781 100644
|
|
|
ddf19c |
--- a/migration/ram.c
|
|
|
ddf19c |
+++ b/migration/ram.c
|
|
|
ddf19c |
@@ -1307,7 +1307,9 @@ static void multifd_recv_terminate_threads(Error *err)
|
|
|
ddf19c |
- normal quit, i.e. everything went fine, just finished
|
|
|
ddf19c |
- error quit: We close the channels so the channel threads
|
|
|
ddf19c |
finish the qio_channel_read_all_eof() */
|
|
|
ddf19c |
- qio_channel_shutdown(p->c, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
|
|
|
ddf19c |
+ if (p->c) {
|
|
|
ddf19c |
+ qio_channel_shutdown(p->c, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
|
|
|
ddf19c |
+ }
|
|
|
ddf19c |
qemu_mutex_unlock(&p->mutex);
|
|
|
ddf19c |
}
|
|
|
ddf19c |
}
|
|
|
ddf19c |
--
|
|
|
ddf19c |
1.8.3.1
|
|
|
ddf19c |
|