|
 |
4ec855 |
From dc98e8dd5c4aad2f3c480a9513ffba89540dcf3f Mon Sep 17 00:00:00 2001
|
|
|
4ec855 |
From: Laszlo Ersek <lersek@redhat.com>
|
|
|
4ec855 |
Date: Thu, 12 Sep 2019 13:05:01 +0100
|
|
|
4ec855 |
Subject: [PATCH 04/22] i386: fix regression parsing multiboot initrd modules
|
|
|
4ec855 |
MIME-Version: 1.0
|
|
|
4ec855 |
Content-Type: text/plain; charset=UTF-8
|
|
|
4ec855 |
Content-Transfer-Encoding: 8bit
|
|
|
4ec855 |
|
|
|
4ec855 |
RH-Author: Laszlo Ersek <lersek@redhat.com>
|
|
|
4ec855 |
Message-id: <20190912130503.14094-5-lersek@redhat.com>
|
|
|
4ec855 |
Patchwork-id: 90434
|
|
|
4ec855 |
O-Subject: [RHEL-8.2.0 qemu-kvm PATCH 4/6] i386: fix regression parsing multiboot initrd modules
|
|
|
4ec855 |
Bugzilla: 1749022
|
|
|
4ec855 |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
From: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
The logic for parsing the multiboot initrd modules was messed up in
|
|
|
4ec855 |
|
|
|
4ec855 |
commit 950c4e6c94b15cd0d8b63891dddd7a8dbf458e6a
|
|
|
4ec855 |
Author: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
4ec855 |
Date: Mon Apr 16 12:17:43 2018 +0100
|
|
|
4ec855 |
|
|
|
4ec855 |
opts: don't silently truncate long option values
|
|
|
4ec855 |
|
|
|
4ec855 |
Causing the length to be undercounter, and the number of modules over
|
|
|
4ec855 |
counted. It also passes NULL to get_opt_value() which was not robust
|
|
|
4ec855 |
at accepting a NULL value.
|
|
|
4ec855 |
|
|
|
4ec855 |
RHEL8 notes:
|
|
|
4ec855 |
|
|
|
4ec855 |
- Context difference in "util/qemu-option.c", function get_opt_value();
|
|
|
4ec855 |
upstream has commit 5c99fa375da1 ("cutils: Provide strchrnul",
|
|
|
4ec855 |
2018-06-29), part of v3.0.0, but downstream lacks it. Harmless, because
|
|
|
4ec855 |
said upstream commit only refactors get_opt_value().
|
|
|
4ec855 |
|
|
|
4ec855 |
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
4ec855 |
Message-Id: <20180514171913.17664-2-berrange@redhat.com>
|
|
|
4ec855 |
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
4ec855 |
Tested-by: Roman Kagan <rkagan@virtuozzo.com>
|
|
|
4ec855 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
4ec855 |
(cherry picked from commit 6e3ad3f0e31b8e31c6c0769d0f474bcd9673e0e5)
|
|
|
4ec855 |
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
4ec855 |
---
|
|
|
4ec855 |
hw/i386/multiboot.c | 3 +--
|
|
|
4ec855 |
util/qemu-option.c | 4 +++-
|
|
|
4ec855 |
2 files changed, 4 insertions(+), 3 deletions(-)
|
|
|
4ec855 |
|
|
|
4ec855 |
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
|
|
|
4ec855 |
index 7a2953e..8e26545 100644
|
|
|
4ec855 |
--- a/hw/i386/multiboot.c
|
|
|
4ec855 |
+++ b/hw/i386/multiboot.c
|
|
|
4ec855 |
@@ -292,8 +292,7 @@ int load_multiboot(FWCfgState *fw_cfg,
|
|
|
4ec855 |
cmdline_len += strlen(kernel_cmdline) + 1;
|
|
|
4ec855 |
if (initrd_filename) {
|
|
|
4ec855 |
const char *r = get_opt_value(initrd_filename, NULL);
|
|
|
4ec855 |
- cmdline_len += strlen(r) + 1;
|
|
|
4ec855 |
- mbs.mb_mods_avail = 1;
|
|
|
4ec855 |
+ cmdline_len += strlen(initrd_filename) + 1;
|
|
|
4ec855 |
while (1) {
|
|
|
4ec855 |
mbs.mb_mods_avail++;
|
|
|
4ec855 |
r = get_opt_value(r, NULL);
|
|
|
4ec855 |
diff --git a/util/qemu-option.c b/util/qemu-option.c
|
|
|
4ec855 |
index ba44a08..a396d60 100644
|
|
|
4ec855 |
--- a/util/qemu-option.c
|
|
|
4ec855 |
+++ b/util/qemu-option.c
|
|
|
4ec855 |
@@ -75,7 +75,9 @@ const char *get_opt_value(const char *p, char **value)
|
|
|
4ec855 |
size_t capacity = 0, length;
|
|
|
4ec855 |
const char *offset;
|
|
|
4ec855 |
|
|
|
4ec855 |
- *value = NULL;
|
|
|
4ec855 |
+ if (value) {
|
|
|
4ec855 |
+ *value = NULL;
|
|
|
4ec855 |
+ }
|
|
|
4ec855 |
while (1) {
|
|
|
4ec855 |
offset = strchr(p, ',');
|
|
|
4ec855 |
if (!offset) {
|
|
|
4ec855 |
--
|
|
|
4ec855 |
1.8.3.1
|
|
|
4ec855 |
|