yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone

Blame SOURCES/kvm-e1000e-Do-not-auto-clear-ICR-bits-which-aren-t-set-i.patch

26ba25
From 4b19800a747e124fed795b013c743c0297fff241 Mon Sep 17 00:00:00 2001
26ba25
From: Xiao Wang <jasowang@redhat.com>
26ba25
Date: Thu, 16 Aug 2018 08:17:06 +0100
26ba25
Subject: [PATCH 1/4] e1000e: Do not auto-clear ICR bits which aren't set in
26ba25
 EIAC
26ba25
26ba25
RH-Author: Xiao Wang <jasowang@redhat.com>
26ba25
Message-id: <1534407427-44794-2-git-send-email-jasowang@redhat.com>
26ba25
Patchwork-id: 81854
26ba25
O-Subject: [RHEL-8.0 qemu-kvm PATCH 1/2] e1000e: Do not auto-clear ICR bits which aren't set in EIAC
26ba25
Bugzilla: 1596024
26ba25
RH-Acked-by: wexu@redhat.com
26ba25
RH-Acked-by: Thomas Huth <thuth@redhat.com>
26ba25
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
26ba25
26ba25
From: Jan Kiszka <jan.kiszka@siemens.com>
26ba25
26ba25
The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when
26ba25
E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the
26ba25
issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid
26ba25
receiver overrun interrupt bursts") and was worked around by
26ba25
745d0bd3af99 ("e1000e: Remove Other from EIAC").
26ba25
26ba25
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
26ba25
Signed-off-by: Jason Wang <jasowang@redhat.com>
26ba25
(cherry picked from commit 2285a00c113469bb3e750ca4921cdb7baaae9e25)
26ba25
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
26ba25
---
26ba25
 hw/net/e1000e_core.c | 4 ----
26ba25
 1 file changed, 4 deletions(-)
26ba25
26ba25
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
26ba25
index c93c466..9504891 100644
26ba25
--- a/hw/net/e1000e_core.c
26ba25
+++ b/hw/net/e1000e_core.c
26ba25
@@ -2022,10 +2022,6 @@ e1000e_msix_notify_one(E1000ECore *core, uint32_t cause, uint32_t int_cfg)
26ba25
 
26ba25
     effective_eiac = core->mac[EIAC] & cause;
26ba25
 
26ba25
-    if (effective_eiac == E1000_ICR_OTHER) {
26ba25
-        effective_eiac |= E1000_ICR_OTHER_CAUSES;
26ba25
-    }
26ba25
-
26ba25
     core->mac[ICR] &= ~effective_eiac;
26ba25
 
26ba25
     if (!(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) {
26ba25
-- 
26ba25
1.8.3.1
26ba25