yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
218e99
From 1bb88d69e0ad951f9436a79e5a5d4bb35bf4076d Mon Sep 17 00:00:00 2001
218e99
From: Kevin Wolf <kwolf@redhat.com>
218e99
Date: Wed, 6 Nov 2013 14:41:15 +0100
218e99
Subject: [PATCH 39/81] apic: Document why cannot_instantiate_with_device_add_yet
218e99
218e99
RH-Author: Kevin Wolf <kwolf@redhat.com>
218e99
Message-id: <1383748882-22831-11-git-send-email-kwolf@redhat.com>
218e99
Patchwork-id: 55536
218e99
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 10/17] apic: Document why cannot_instantiate_with_device_add_yet
218e99
Bugzilla: 1001216
218e99
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
218e99
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
218e99
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
218e99
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
218e99
218e99
From: Markus Armbruster <armbru@redhat.com>
218e99
218e99
Signed-off-by: Markus Armbruster <armbru@redhat.com>
218e99
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
218e99
(cherry picked from pending upstream submission)
218e99
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
218e99
---
218e99
 hw/intc/apic_common.c | 6 +++++-
218e99
 1 file changed, 5 insertions(+), 1 deletion(-)
218e99
218e99
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
218e99
---
218e99
 hw/intc/apic_common.c |    6 +++++-
218e99
 1 files changed, 5 insertions(+), 1 deletions(-)
218e99
218e99
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
218e99
index 208e7b1..ff413de 100644
218e99
--- a/hw/intc/apic_common.c
218e99
+++ b/hw/intc/apic_common.c
218e99
@@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass, void *data)
218e99
 
218e99
     dc->vmsd = &vmstate_apic_common;
218e99
     dc->reset = apic_reset_common;
218e99
-    dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
218e99
     dc->props = apic_properties_common;
218e99
     idc->init = apic_init_common;
218e99
+    /*
218e99
+     * Reason: APIC and CPU need to be wired up by
218e99
+     * x86_cpu_apic_create()
218e99
+     */
218e99
+    dc->cannot_instantiate_with_device_add_yet = true;
218e99
 }
218e99
 
218e99
 static const TypeInfo apic_common_type = {
218e99
-- 
218e99
1.7.1
218e99