yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
26ba25
From 4b889f33761a4447998b16846bfb983519def96d Mon Sep 17 00:00:00 2001
26ba25
From: Thomas Huth <thuth@redhat.com>
26ba25
Date: Wed, 28 Nov 2018 07:23:59 +0000
26ba25
Subject: [PATCH 07/16] Declare cirrus-vga as deprecated
26ba25
26ba25
RH-Author: Thomas Huth <thuth@redhat.com>
26ba25
Message-id: <1543389839-8995-1-git-send-email-thuth@redhat.com>
26ba25
Patchwork-id: 83178
26ba25
O-Subject: [RHEL8 qemu-kvm PATCH v2] Declare cirrus-vga as deprecated
26ba25
Bugzilla: 1651994
26ba25
RH-Acked-by: Gerd Hoffmann <kraxel@redhat.com>
26ba25
RH-Acked-by: Markus Armbruster <armbru@redhat.com>
26ba25
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
26ba25
26ba25
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1651994
26ba25
Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=19300792
26ba25
Upstream: n/a (downstream only)
26ba25
Branch: rhel8/master-2.12.0
26ba25
Branch: rhel8/master-3.0.0
26ba25
26ba25
The "cirrus" device in qemu-kvm is considered as a legacy device, which
26ba25
also had a lot of security issues in the past. KVM guest should preferably
26ba25
use "stdvga", "virtio-vga" or "qxl" as graphics card nowadays instead.
26ba25
To avoid that we have to carry along the legacy "cirrus" device in
26ba25
downstream qemu-kvm forever, let's mark it as deprecated in RHEL8 now,
26ba25
so that we can finally remove it in RHEL9.
26ba25
26ba25
Signed-off-by: Thomas Huth <thuth@redhat.com>
26ba25
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
26ba25
---
26ba25
 hw/display/cirrus_vga.c | 3 +++
26ba25
 1 file changed, 3 insertions(+)
26ba25
26ba25
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
26ba25
index 014268a..29d6055 100644
26ba25
--- a/hw/display/cirrus_vga.c
26ba25
+++ b/hw/display/cirrus_vga.c
26ba25
@@ -3098,6 +3098,9 @@ static void pci_cirrus_vga_realize(PCIDevice *dev, Error **errp)
26ba25
      PCIDeviceClass *pc = PCI_DEVICE_GET_CLASS(dev);
26ba25
      int16_t device_id = pc->device_id;
26ba25
 
26ba25
+     warn_report("'cirrus-vga' is deprecated, "
26ba25
+                 "please use a different VGA card instead");
26ba25
+
26ba25
      /* follow real hardware, cirrus card emulated has 4 MB video memory.
26ba25
        Also accept 8 MB/16 MB for backward compatibility. */
26ba25
      if (s->vga.vram_size_mb != 4 && s->vga.vram_size_mb != 8 &&
26ba25
-- 
26ba25
1.8.3.1
26ba25