|
 |
9ae3a8 |
From 86a622181cfcb4205877595fa53b3bbc87cf9431 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 6 Nov 2013 14:41:19 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 43/81] vt82c686: Clean up use of cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1383748882-22831-15-git-send-email-kwolf@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 55540
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 14/17] vt82c686: Clean up use of cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
Bugzilla: 1001216
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
A VT82C686B southbridge has multiple functions. We model each
|
|
|
9ae3a8 |
function as a separate qdev. One of them need some special wiring set
|
|
|
9ae3a8 |
up in mips_fulong2e_init() to work: the ISA bridge at 05.0.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
The IDE controller at 05.1 (via-ide) has always had
|
|
|
9ae3a8 |
cannot_instantiate_with_device_add_yet set, but there is no obvious
|
|
|
9ae3a8 |
reason why device_add could not work for them. Drop it.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
9ae3a8 |
(cherry picked from pending upstream submission)
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/ide/via.c | 1 -
|
|
|
9ae3a8 |
hw/isa/vt82c686.c | 6 +++++-
|
|
|
9ae3a8 |
2 files changed, 5 insertions(+), 2 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/ide/via.c | 1 -
|
|
|
9ae3a8 |
hw/isa/vt82c686.c | 6 +++++-
|
|
|
9ae3a8 |
2 files changed, 5 insertions(+), 2 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/ide/via.c b/hw/ide/via.c
|
|
|
9ae3a8 |
index 6ba99c8..326722c 100644
|
|
|
9ae3a8 |
--- a/hw/ide/via.c
|
|
|
9ae3a8 |
+++ b/hw/ide/via.c
|
|
|
9ae3a8 |
@@ -224,7 +224,6 @@ static void via_ide_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
k->revision = 0x06;
|
|
|
9ae3a8 |
k->class_id = PCI_CLASS_STORAGE_IDE;
|
|
|
9ae3a8 |
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
static const TypeInfo via_ide_info = {
|
|
|
9ae3a8 |
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
|
|
|
9ae3a8 |
index 563e154..bb84414 100644
|
|
|
9ae3a8 |
--- a/hw/isa/vt82c686.c
|
|
|
9ae3a8 |
+++ b/hw/isa/vt82c686.c
|
|
|
9ae3a8 |
@@ -468,8 +468,12 @@ static void via_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
k->class_id = PCI_CLASS_BRIDGE_ISA;
|
|
|
9ae3a8 |
k->revision = 0x40;
|
|
|
9ae3a8 |
dc->desc = "ISA bridge";
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
dc->vmsd = &vmstate_via;
|
|
|
9ae3a8 |
+ /*
|
|
|
9ae3a8 |
+ * Reason: part of VIA VT82C686 southbridge, needs to be wired up,
|
|
|
9ae3a8 |
+ * e.g. by mips_fulong2e_init()
|
|
|
9ae3a8 |
+ */
|
|
|
9ae3a8 |
+ dc->cannot_instantiate_with_device_add_yet = true;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
static const TypeInfo via_info = {
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|