From 9cf495aabeeaf4fdccae83d748a70936e3bf26ab Mon Sep 17 00:00:00 2001

From: Paolo Bonzini <pbonzini@redhat.com>

Date: Mon, 22 Jul 2019 18:22:07 +0100

Subject: [PATCH 26/39] target/i386: kvm: Delete VMX migration blocker on vCPU

 init failure

RH-Author: Paolo Bonzini <pbonzini@redhat.com>

Message-id: <20190722182220.19374-6-pbonzini@redhat.com>

Patchwork-id: 89624

O-Subject: [RHEL-8.1.0 PATCH qemu-kvm v3 05/18] target/i386: kvm: Delete VMX migration blocker on vCPU init failure

Bugzilla: 1689269

RH-Acked-by: Peter Xu <zhexu@redhat.com>

RH-Acked-by: Laurent Vivier <lvivier@redhat.com>

RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

From: Liran Alon <liran.alon@oracle.com>

Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker")

added migration blocker for vCPU exposed with Intel VMX because QEMU

doesn't yet contain code to support migration of nested virtualization

workloads.

However, that commit missed adding deletion of the migration blocker in

case init of vCPU failed. Similar to invtsc_mig_blocker. This commit fix

that issue.

Fixes: d98f26073beb ("target/i386: kvm: add VMX migration blocker")

Signed-off-by: Liran Alon <liran.alon@oracle.com>

Reviewed-by: Maran Wilson <maran.wilson@oracle.com>

Message-Id: <20190619162140.133674-2-liran.alon@oracle.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

(cherry picked from commit 6b2341eeea43c00b8e266026cec84d57af1484dc)

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 target/i386/kvm.c | 7 +++++--

 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/target/i386/kvm.c b/target/i386/kvm.c

index 875412c..8e861a1 100644

--- a/target/i386/kvm.c

+++ b/target/i386/kvm.c

@@ -798,7 +798,7 @@ int kvm_arch_init_vcpu(CPUState *cs)

     r = kvm_arch_set_tsc_khz(cs);

     if (r < 0) {

-        goto fail;

+        return r;

     }

     /* vcpu's TSC frequency is either specified by user, or following

@@ -1142,7 +1142,7 @@ int kvm_arch_init_vcpu(CPUState *cs)

             if (local_err) {

                 error_report_err(local_err);

                 error_free(invtsc_mig_blocker);

-                return r;

+                goto fail2;

             }

             /* for savevm */

             vmstate_x86_cpu.unmigratable = 1;

@@ -1190,6 +1190,9 @@ int kvm_arch_init_vcpu(CPUState *cs)

  fail:

     migrate_del_blocker(invtsc_mig_blocker);

+ fail2:

+    migrate_del_blocker(vmx_mig_blocker);

+

     return r;

 }

-- 

1.8.3.1