|
 |
bf143f |
From 67ebb71d56e95adf185ab4971939e31c4c899863 Mon Sep 17 00:00:00 2001
|
|
|
bf143f |
From: Matthew Rosato <mjrosato@linux.ibm.com>
|
|
|
bf143f |
Date: Fri, 3 Dec 2021 09:27:04 -0500
|
|
|
bf143f |
Subject: [PATCH 02/42] s390x/pci: don't use hard-coded dma range in reg_ioat
|
|
|
bf143f |
MIME-Version: 1.0
|
|
|
bf143f |
Content-Type: text/plain; charset=UTF-8
|
|
|
bf143f |
Content-Transfer-Encoding: 8bit
|
|
|
bf143f |
|
|
|
bf143f |
RH-Author: Cédric Le Goater <clg@redhat.com>
|
|
|
bf143f |
RH-MergeRequest: 226: s390: Enhanced Interpretation for PCI Functions and Secure Execution guest dump
|
|
|
bf143f |
RH-Bugzilla: 1664378 2043909
|
|
|
bf143f |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
bf143f |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
bf143f |
RH-Acked-by: Jon Maloy <jmaloy@redhat.com>
|
|
|
bf143f |
RH-Commit: [2/41] c7897321f9848ef8f115130832774bbcd6724f03
|
|
|
bf143f |
|
|
|
bf143f |
Instead use the values from clp info, they will either be the hard-coded
|
|
|
bf143f |
values or what came from the host driver via vfio.
|
|
|
bf143f |
|
|
|
bf143f |
Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure")
|
|
|
bf143f |
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
|
|
|
bf143f |
Reviewed-by: Eric Farman <farman@linux.ibm.com>
|
|
|
bf143f |
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
|
|
|
bf143f |
Message-Id: <20211203142706.427279-3-mjrosato@linux.ibm.com>
|
|
|
bf143f |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
bf143f |
(cherry picked from commit df7ce0a94d9283f0656b4bc0f21566973ff649a3)
|
|
|
bf143f |
Signed-off-by: Cédric Le Goater <clg@redhat.com>
|
|
|
bf143f |
---
|
|
|
bf143f |
hw/s390x/s390-pci-inst.c | 9 +++++----
|
|
|
bf143f |
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
bf143f |
|
|
|
bf143f |
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
|
|
|
bf143f |
index 1c8ad91175..11b7f6bfa1 100644
|
|
|
bf143f |
--- a/hw/s390x/s390-pci-inst.c
|
|
|
bf143f |
+++ b/hw/s390x/s390-pci-inst.c
|
|
|
bf143f |
@@ -916,9 +916,10 @@ int pci_dereg_irqs(S390PCIBusDevice *pbdev)
|
|
|
bf143f |
return 0;
|
|
|
bf143f |
}
|
|
|
bf143f |
|
|
|
bf143f |
-static int reg_ioat(CPUS390XState *env, S390PCIIOMMU *iommu, ZpciFib fib,
|
|
|
bf143f |
+static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,
|
|
|
bf143f |
uintptr_t ra)
|
|
|
bf143f |
{
|
|
|
bf143f |
+ S390PCIIOMMU *iommu = pbdev->iommu;
|
|
|
bf143f |
uint64_t pba = ldq_p(&fib.pba);
|
|
|
bf143f |
uint64_t pal = ldq_p(&fib.pal);
|
|
|
bf143f |
uint64_t g_iota = ldq_p(&fib.iota);
|
|
|
bf143f |
@@ -927,7 +928,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIIOMMU *iommu, ZpciFib fib,
|
|
|
bf143f |
|
|
|
bf143f |
pba &= ~0xfff;
|
|
|
bf143f |
pal |= 0xfff;
|
|
|
bf143f |
- if (pba > pal || pba < ZPCI_SDMA_ADDR || pal > ZPCI_EDMA_ADDR) {
|
|
|
bf143f |
+ if (pba > pal || pba < pbdev->zpci_fn.sdma || pal > pbdev->zpci_fn.edma) {
|
|
|
bf143f |
s390_program_interrupt(env, PGM_OPERAND, ra);
|
|
|
bf143f |
return -EINVAL;
|
|
|
bf143f |
}
|
|
|
bf143f |
@@ -1125,7 +1126,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,
|
|
|
bf143f |
} else if (pbdev->iommu->enabled) {
|
|
|
bf143f |
cc = ZPCI_PCI_LS_ERR;
|
|
|
bf143f |
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
|
|
|
bf143f |
- } else if (reg_ioat(env, pbdev->iommu, fib, ra)) {
|
|
|
bf143f |
+ } else if (reg_ioat(env, pbdev, fib, ra)) {
|
|
|
bf143f |
cc = ZPCI_PCI_LS_ERR;
|
|
|
bf143f |
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
|
|
|
bf143f |
}
|
|
|
bf143f |
@@ -1150,7 +1151,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,
|
|
|
bf143f |
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
|
|
|
bf143f |
} else {
|
|
|
bf143f |
pci_dereg_ioat(pbdev->iommu);
|
|
|
bf143f |
- if (reg_ioat(env, pbdev->iommu, fib, ra)) {
|
|
|
bf143f |
+ if (reg_ioat(env, pbdev, fib, ra)) {
|
|
|
bf143f |
cc = ZPCI_PCI_LS_ERR;
|
|
|
bf143f |
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
|
|
|
bf143f |
}
|
|
|
bf143f |
--
|
|
|
bf143f |
2.37.3
|
|
|
bf143f |
|