|
 |
4841a6 |
From f3125f6379cbc070e9acaf58d0ec37972992744b Mon Sep 17 00:00:00 2001
|
|
|
4841a6 |
From: Thomas Huth <thuth@redhat.com>
|
|
|
4841a6 |
Date: Wed, 6 Apr 2022 10:56:26 +0200
|
|
|
4841a6 |
Subject: [PATCH 4/5] s390x/css: fix PMCW invalid mask
|
|
|
4841a6 |
|
|
|
4841a6 |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
4841a6 |
RH-MergeRequest: 145: s390x/css: fix PMCW invalid mask
|
|
|
4841a6 |
RH-Commit: [1/1] fbf192f651aa668af56ca5c77455595fcdb19508
|
|
|
4841a6 |
RH-Bugzilla: 2071070
|
|
|
4841a6 |
RH-Acked-by: Jon Maloy <jmaloy@redhat.com>
|
|
|
4841a6 |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
4841a6 |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
4841a6 |
|
|
|
4841a6 |
Bugzilla: http://bugzilla.redhat.com/2071070
|
|
|
4841a6 |
|
|
|
4841a6 |
commit 2df59b73e0864f021f6179f32f7ed364f6d4f38d
|
|
|
4841a6 |
Author: Nico Boehr <nrb@linux.ibm.com>
|
|
|
4841a6 |
Date: Thu Dec 16 14:16:57 2021 +0100
|
|
|
4841a6 |
|
|
|
4841a6 |
s390x/css: fix PMCW invalid mask
|
|
|
4841a6 |
|
|
|
4841a6 |
Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But,
|
|
|
4841a6 |
as per the principles of operation, bit 5 is ignored in MSCH and bits 0,
|
|
|
4841a6 |
1, 6 and 7 need to be zero.
|
|
|
4841a6 |
|
|
|
4841a6 |
As both PMCW_FLAGS_MASK_INVALID and ioinst_schib_valid() are only used
|
|
|
4841a6 |
by ioinst_handle_msch(), adjust the mask accordingly.
|
|
|
4841a6 |
|
|
|
4841a6 |
Fixes: db1c8f53bfb1 ("s390: Channel I/O basic definitions.")
|
|
|
4841a6 |
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
|
|
|
4841a6 |
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
|
|
|
4841a6 |
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
|
|
|
4841a6 |
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
|
|
|
4841a6 |
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
4841a6 |
Message-Id: <20211216131657.1057978-1-nrb@linux.ibm.com>
|
|
|
4841a6 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
4841a6 |
|
|
|
4841a6 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
4841a6 |
---
|
|
|
4841a6 |
include/hw/s390x/ioinst.h | 2 +-
|
|
|
4841a6 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
4841a6 |
|
|
|
4841a6 |
diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h
|
|
|
4841a6 |
index 3771fff9d4..ea8d0f2444 100644
|
|
|
4841a6 |
--- a/include/hw/s390x/ioinst.h
|
|
|
4841a6 |
+++ b/include/hw/s390x/ioinst.h
|
|
|
4841a6 |
@@ -107,7 +107,7 @@ QEMU_BUILD_BUG_MSG(sizeof(PMCW) != 28, "size of PMCW is wrong");
|
|
|
4841a6 |
#define PMCW_FLAGS_MASK_MP 0x0004
|
|
|
4841a6 |
#define PMCW_FLAGS_MASK_TF 0x0002
|
|
|
4841a6 |
#define PMCW_FLAGS_MASK_DNV 0x0001
|
|
|
4841a6 |
-#define PMCW_FLAGS_MASK_INVALID 0x0700
|
|
|
4841a6 |
+#define PMCW_FLAGS_MASK_INVALID 0xc300
|
|
|
4841a6 |
|
|
|
4841a6 |
#define PMCW_CHARS_MASK_ST 0x00e00000
|
|
|
4841a6 |
#define PMCW_CHARS_MASK_MBFC 0x00000004
|
|
|
4841a6 |
--
|
|
|
4841a6 |
2.27.0
|
|
|
4841a6 |
|