|
 |
ed5979 |
From 2f5369f0effaa23be746f9b5d9f6a0bfc346fb7d Mon Sep 17 00:00:00 2001
|
|
|
ed5979 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
ed5979 |
Date: Thu, 12 Jan 2023 20:14:52 +0100
|
|
|
ed5979 |
Subject: [PATCH 02/20] qemu-img commit: Report errors while closing the image
|
|
|
ed5979 |
|
|
|
ed5979 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
ed5979 |
RH-MergeRequest: 143: qemu-img: Fix exit code for errors closing the image
|
|
|
ed5979 |
RH-Bugzilla: 2150180
|
|
|
ed5979 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
ed5979 |
RH-Acked-by: Hanna Czenczek <hreitz@redhat.com>
|
|
|
ed5979 |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
ed5979 |
RH-Commit: [2/4] faedd43355463b1210a3f21ecd430f478bd06f5a (kmwolf/centos-qemu-kvm)
|
|
|
ed5979 |
|
|
|
ed5979 |
blk_unref() can't report any errors that happen while closing the image.
|
|
|
ed5979 |
For example, if qcow2 hits an -ENOSPC error while writing out dirty
|
|
|
ed5979 |
bitmaps when it's closed, it prints error messages to stderr, but
|
|
|
ed5979 |
'qemu-img commit' won't see any error return value and will therefore
|
|
|
ed5979 |
look successful with exit code 0.
|
|
|
ed5979 |
|
|
|
ed5979 |
In order to fix this, manually inactivate the image first before calling
|
|
|
ed5979 |
blk_unref(). This already performs the operations that would be most
|
|
|
ed5979 |
likely to fail while closing the image, but it can still return errors.
|
|
|
ed5979 |
|
|
|
ed5979 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ed5979 |
Message-Id: <20230112191454.169353-3-kwolf@redhat.com>
|
|
|
ed5979 |
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
|
|
|
ed5979 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ed5979 |
(cherry picked from commit 44efba2d713aca076c411594d0c1a2b99155eeb3)
|
|
|
ed5979 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ed5979 |
---
|
|
|
ed5979 |
qemu-img.c | 13 +++++++++++++
|
|
|
ed5979 |
1 file changed, 13 insertions(+)
|
|
|
ed5979 |
|
|
|
ed5979 |
diff --git a/qemu-img.c b/qemu-img.c
|
|
|
ed5979 |
index a9b3a8103c..3cbdda9f76 100644
|
|
|
ed5979 |
--- a/qemu-img.c
|
|
|
ed5979 |
+++ b/qemu-img.c
|
|
|
ed5979 |
@@ -449,6 +449,11 @@ static BlockBackend *img_open(bool image_opts,
|
|
|
ed5979 |
blk = img_open_file(filename, NULL, fmt, flags, writethrough, quiet,
|
|
|
ed5979 |
force_share);
|
|
|
ed5979 |
}
|
|
|
ed5979 |
+
|
|
|
ed5979 |
+ if (blk) {
|
|
|
ed5979 |
+ blk_set_force_allow_inactivate(blk);
|
|
|
ed5979 |
+ }
|
|
|
ed5979 |
+
|
|
|
ed5979 |
return blk;
|
|
|
ed5979 |
}
|
|
|
ed5979 |
|
|
|
ed5979 |
@@ -1119,6 +1124,14 @@ unref_backing:
|
|
|
ed5979 |
done:
|
|
|
ed5979 |
qemu_progress_end();
|
|
|
ed5979 |
|
|
|
ed5979 |
+ /*
|
|
|
ed5979 |
+ * Manually inactivate the image first because this way we can know whether
|
|
|
ed5979 |
+ * an error occurred. blk_unref() doesn't tell us about failures.
|
|
|
ed5979 |
+ */
|
|
|
ed5979 |
+ ret = bdrv_inactivate_all();
|
|
|
ed5979 |
+ if (ret < 0 && !local_err) {
|
|
|
ed5979 |
+ error_setg_errno(&local_err, -ret, "Error while closing the image");
|
|
|
ed5979 |
+ }
|
|
|
ed5979 |
blk_unref(blk);
|
|
|
ed5979 |
|
|
|
ed5979 |
if (local_err) {
|
|
|
ed5979 |
--
|
|
|
ed5979 |
2.31.1
|
|
|
ed5979 |
|