|
 |
9ae3a8 |
From 085e956d2dbbc280727760ffa620b8a22db1cb6e Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 6 Nov 2013 14:41:17 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 41/81] ich9: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1383748882-22831-13-git-send-email-kwolf@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 55538
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 12/17] ich9: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
Bugzilla: 1001216
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
An ICH9 southbridge contains several PCI devices, some of them with
|
|
|
9ae3a8 |
multiple functions. We model each function as a separate qdev. Two
|
|
|
9ae3a8 |
of them need some special wiring set up in pc_q35_init() to work: the
|
|
|
9ae3a8 |
LPC controller at 00:1f.0, and the SMBus controller at 00:1f.3.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
9ae3a8 |
(cherry picked from pending upstream submission)
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/i2c/smbus_ich9.c | 6 +++++-
|
|
|
9ae3a8 |
hw/isa/lpc_ich9.c | 7 +++++--
|
|
|
9ae3a8 |
2 files changed, 10 insertions(+), 3 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/i2c/smbus_ich9.c | 6 +++++-
|
|
|
9ae3a8 |
hw/isa/lpc_ich9.c | 7 +++++--
|
|
|
9ae3a8 |
2 files changed, 10 insertions(+), 3 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c
|
|
|
9ae3a8 |
index c1ffa34..8d47eaf 100644
|
|
|
9ae3a8 |
--- a/hw/i2c/smbus_ich9.c
|
|
|
9ae3a8 |
+++ b/hw/i2c/smbus_ich9.c
|
|
|
9ae3a8 |
@@ -97,11 +97,15 @@ static void ich9_smb_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
k->device_id = PCI_DEVICE_ID_INTEL_ICH9_6;
|
|
|
9ae3a8 |
k->revision = ICH9_A2_SMB_REVISION;
|
|
|
9ae3a8 |
k->class_id = PCI_CLASS_SERIAL_SMBUS;
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
dc->vmsd = &vmstate_ich9_smbus;
|
|
|
9ae3a8 |
dc->desc = "ICH9 SMBUS Bridge";
|
|
|
9ae3a8 |
k->init = ich9_smbus_initfn;
|
|
|
9ae3a8 |
k->config_write = ich9_smbus_write_config;
|
|
|
9ae3a8 |
+ /*
|
|
|
9ae3a8 |
+ * Reason: part of ICH9 southbridge, needs to be wired up by
|
|
|
9ae3a8 |
+ * pc_q35_init()
|
|
|
9ae3a8 |
+ */
|
|
|
9ae3a8 |
+ dc->cannot_instantiate_with_device_add_yet = true;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
i2c_bus *ich9_smb_init(PCIBus *bus, int devfn, uint32_t smb_io_base)
|
|
|
9ae3a8 |
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
|
|
|
9ae3a8 |
index 580e9ac..4f834b9 100644
|
|
|
9ae3a8 |
--- a/hw/isa/lpc_ich9.c
|
|
|
9ae3a8 |
+++ b/hw/isa/lpc_ich9.c
|
|
|
9ae3a8 |
@@ -603,14 +603,17 @@ static void ich9_lpc_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
dc->reset = ich9_lpc_reset;
|
|
|
9ae3a8 |
k->init = ich9_lpc_initfn;
|
|
|
9ae3a8 |
dc->vmsd = &vmstate_ich9_lpc;
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
k->config_write = ich9_lpc_config_write;
|
|
|
9ae3a8 |
dc->desc = "ICH9 LPC bridge";
|
|
|
9ae3a8 |
k->vendor_id = PCI_VENDOR_ID_INTEL;
|
|
|
9ae3a8 |
k->device_id = PCI_DEVICE_ID_INTEL_ICH9_8;
|
|
|
9ae3a8 |
k->revision = ICH9_A2_LPC_REVISION;
|
|
|
9ae3a8 |
k->class_id = PCI_CLASS_BRIDGE_ISA;
|
|
|
9ae3a8 |
-
|
|
|
9ae3a8 |
+ /*
|
|
|
9ae3a8 |
+ * Reason: part of ICH9 southbridge, needs to be wired up by
|
|
|
9ae3a8 |
+ * pc_q35_init()
|
|
|
9ae3a8 |
+ */
|
|
|
9ae3a8 |
+ dc->cannot_instantiate_with_device_add_yet = true;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
static const TypeInfo ich9_lpc_info = {
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|