From d5526e43ccf3532aa3a0f592e6df5740983a94e2 Mon Sep 17 00:00:00 2001

From: Paolo Bonzini <pbonzini@redhat.com>

Date: Fri, 22 Nov 2019 11:53:35 +0000

Subject: [PATCH 02/16] i386: Add x-force-features option for testing

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

RH-Author: Paolo Bonzini <pbonzini@redhat.com>

Message-id: <20191122115348.25000-3-pbonzini@redhat.com>

Patchwork-id: 92602

O-Subject: [RHEL8.2/rhel qemu-kvm PATCH 02/15] i386: Add x-force-features option for testing

Bugzilla: 1689270

RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

RH-Acked-by: Eduardo Habkost <ehabkost@redhat.com>

RH-Acked-by: Maxim Levitsky <mlevitsk@redhat.com>

From: Eduardo Habkost <ehabkost@redhat.com>

Add a new option that can be used to disable feature flag

filtering.  This will allow CPU model compatibility test cases to

work without host hardware dependencies.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Message-Id: <20190628002844.24894-3-ehabkost@redhat.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

(cherry picked from commit dac1deae658539e39966e12b12378a28e3dc8441)

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 target/i386/cpu.c | 8 ++++++--

 target/i386/cpu.h | 6 ++++++

 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c

index c69116c..8c1338f 100644

--- a/target/i386/cpu.c

+++ b/target/i386/cpu.c

@@ -5019,8 +5019,11 @@ static int x86_cpu_filter_features(X86CPU *cpu)

         uint32_t host_feat =

             x86_cpu_get_supported_feature_word(w, false);

         uint32_t requested_features = env->features[w];

-        env->features[w] &= host_feat;

-        cpu->filtered_features[w] = requested_features & ~env->features[w];

+        uint32_t available_features = requested_features & host_feat;

+        if (!cpu->force_features) {

+            env->features[w] = available_features;

+        }

+        cpu->filtered_features[w] = requested_features & ~available_features;

         if (cpu->filtered_features[w]) {

             rv = 1;

         }

@@ -5680,6 +5683,7 @@ static Property x86_cpu_properties[] = {

     DEFINE_PROP_BOOL("hv-frequencies", X86CPU, hyperv_frequencies, false),

     DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, true),

     DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false),

+    DEFINE_PROP_BOOL("x-force-features", X86CPU, force_features, false),

     DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true),

     DEFINE_PROP_UINT32("phys-bits", X86CPU, phys_bits, 0),

     DEFINE_PROP_BOOL("host-phys-bits", X86CPU, host_phys_bits, false),

diff --git a/target/i386/cpu.h b/target/i386/cpu.h

index add8b60..1ad54bd 100644

--- a/target/i386/cpu.h

+++ b/target/i386/cpu.h

@@ -1394,6 +1394,12 @@ struct X86CPU {

     bool hyperv_frequencies;

     bool check_cpuid;

     bool enforce_cpuid;

+    /*

+     * Force features to be enabled even if the host doesn't support them.

+     * This is dangerous and should be done only for testing CPUID

+     * compatibility.

+     */

+    bool force_features;

     bool expose_kvm;

     bool expose_tcg;

     bool migratable;

-- 

1.8.3.1