|
 |
ae23c9 |
From 6508e23a5053680509754d719a19b04754e1fbdc Mon Sep 17 00:00:00 2001
|
|
|
ae23c9 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Date: Thu, 10 Jan 2019 12:44:38 +0000
|
|
|
ae23c9 |
Subject: [PATCH 08/14] gluster: Support auto-read-only option
|
|
|
ae23c9 |
|
|
|
ae23c9 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Message-id: <20190110124442.30132-9-kwolf@redhat.com>
|
|
|
ae23c9 |
Patchwork-id: 83959
|
|
|
ae23c9 |
O-Subject: [RHEL-8.0 qemu-kvm PATCH 08/12] gluster: Support auto-read-only option
|
|
|
ae23c9 |
Bugzilla: 1644996
|
|
|
ae23c9 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
If read-only=off, but auto-read-only=on is given, open the file
|
|
|
ae23c9 |
read-write if we have the permissions, but instead of erroring out for
|
|
|
ae23c9 |
read-only files, just degrade to read-only.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Reviewed-by: Niels de Vos <ndevos@redhat.com>
|
|
|
ae23c9 |
(cherry picked from commit 54ea21bd16202c4a3e43c67b573b5d1aa2ec1c0c)
|
|
|
ae23c9 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
ae23c9 |
---
|
|
|
ae23c9 |
block/gluster.c | 12 ++++++++++--
|
|
|
ae23c9 |
1 file changed, 10 insertions(+), 2 deletions(-)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
diff --git a/block/gluster.c b/block/gluster.c
|
|
|
ae23c9 |
index cecfe09..8c13002 100644
|
|
|
ae23c9 |
--- a/block/gluster.c
|
|
|
ae23c9 |
+++ b/block/gluster.c
|
|
|
ae23c9 |
@@ -849,8 +849,16 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options,
|
|
|
ae23c9 |
qemu_gluster_parse_flags(bdrv_flags, &open_flags);
|
|
|
ae23c9 |
|
|
|
ae23c9 |
s->fd = glfs_open(s->glfs, gconf->path, open_flags);
|
|
|
ae23c9 |
- if (!s->fd) {
|
|
|
ae23c9 |
- ret = -errno;
|
|
|
ae23c9 |
+ ret = s->fd ? 0 : -errno;
|
|
|
ae23c9 |
+
|
|
|
ae23c9 |
+ if (ret == -EACCES || ret == -EROFS) {
|
|
|
ae23c9 |
+ /* Try to degrade to read-only, but if it doesn't work, still use the
|
|
|
ae23c9 |
+ * normal error message. */
|
|
|
ae23c9 |
+ if (bdrv_apply_auto_read_only(bs, NULL, NULL) == 0) {
|
|
|
ae23c9 |
+ open_flags = (open_flags & ~O_RDWR) | O_RDONLY;
|
|
|
ae23c9 |
+ s->fd = glfs_open(s->glfs, gconf->path, open_flags);
|
|
|
ae23c9 |
+ ret = s->fd ? 0 : -errno;
|
|
|
ae23c9 |
+ }
|
|
|
ae23c9 |
}
|
|
|
ae23c9 |
|
|
|
ae23c9 |
s->supports_seek_data = qemu_gluster_test_seek(s->fd);
|
|
|
ae23c9 |
--
|
|
|
ae23c9 |
1.8.3.1
|
|
|
ae23c9 |
|