|
 |
ae23c9 |
From 4b19800a747e124fed795b013c743c0297fff241 Mon Sep 17 00:00:00 2001
|
|
|
ae23c9 |
From: Xiao Wang <jasowang@redhat.com>
|
|
|
ae23c9 |
Date: Thu, 16 Aug 2018 08:17:06 +0100
|
|
|
ae23c9 |
Subject: [PATCH 1/4] e1000e: Do not auto-clear ICR bits which aren't set in
|
|
|
ae23c9 |
EIAC
|
|
|
ae23c9 |
|
|
|
ae23c9 |
RH-Author: Xiao Wang <jasowang@redhat.com>
|
|
|
ae23c9 |
Message-id: <1534407427-44794-2-git-send-email-jasowang@redhat.com>
|
|
|
ae23c9 |
Patchwork-id: 81854
|
|
|
ae23c9 |
O-Subject: [RHEL-8.0 qemu-kvm PATCH 1/2] e1000e: Do not auto-clear ICR bits which aren't set in EIAC
|
|
|
ae23c9 |
Bugzilla: 1596024
|
|
|
ae23c9 |
RH-Acked-by: wexu@redhat.com
|
|
|
ae23c9 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
From: Jan Kiszka <jan.kiszka@siemens.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when
|
|
|
ae23c9 |
E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the
|
|
|
ae23c9 |
issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid
|
|
|
ae23c9 |
receiver overrun interrupt bursts") and was worked around by
|
|
|
ae23c9 |
745d0bd3af99 ("e1000e: Remove Other from EIAC").
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
|
|
|
ae23c9 |
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
|
|
ae23c9 |
(cherry picked from commit 2285a00c113469bb3e750ca4921cdb7baaae9e25)
|
|
|
ae23c9 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
ae23c9 |
---
|
|
|
ae23c9 |
hw/net/e1000e_core.c | 4 ----
|
|
|
ae23c9 |
1 file changed, 4 deletions(-)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
|
|
|
ae23c9 |
index c93c466..9504891 100644
|
|
|
ae23c9 |
--- a/hw/net/e1000e_core.c
|
|
|
ae23c9 |
+++ b/hw/net/e1000e_core.c
|
|
|
ae23c9 |
@@ -2022,10 +2022,6 @@ e1000e_msix_notify_one(E1000ECore *core, uint32_t cause, uint32_t int_cfg)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
effective_eiac = core->mac[EIAC] & cause;
|
|
|
ae23c9 |
|
|
|
ae23c9 |
- if (effective_eiac == E1000_ICR_OTHER) {
|
|
|
ae23c9 |
- effective_eiac |= E1000_ICR_OTHER_CAUSES;
|
|
|
ae23c9 |
- }
|
|
|
ae23c9 |
-
|
|
|
ae23c9 |
core->mac[ICR] &= ~effective_eiac;
|
|
|
ae23c9 |
|
|
|
ae23c9 |
if (!(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) {
|
|
|
ae23c9 |
--
|
|
|
ae23c9 |
1.8.3.1
|
|
|
ae23c9 |
|