|
 |
9ae3a8 |
From a1a7f1301c20582d3326e33acd94a4c198c60bcd Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
Date: Fri, 18 Oct 2013 08:14:27 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 02/81] cow: make writes go at a less indecent speed
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1382084091-16636-3-git-send-email-pbonzini@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 54985
|
|
|
9ae3a8 |
O-Subject: [RHEL 7.0 qemu-kvm PATCH 02/26] cow: make writes go at a less indecent speed
|
|
|
9ae3a8 |
Bugzilla: 989646
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Only sync once per write, rather than once per sector.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit 26ae980492920e417bc91761cc85950f18e41f85)
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
block/cow.c | 19 ++++++++++++++++---
|
|
|
9ae3a8 |
1 file changed, 16 insertions(+), 3 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
block/cow.c | 19 ++++++++++++++++---
|
|
|
9ae3a8 |
1 files changed, 16 insertions(+), 3 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/block/cow.c b/block/cow.c
|
|
|
9ae3a8 |
index c12088b..2f72334 100644
|
|
|
9ae3a8 |
--- a/block/cow.c
|
|
|
9ae3a8 |
+++ b/block/cow.c
|
|
|
9ae3a8 |
@@ -106,7 +106,7 @@ static int cow_open(BlockDriverState *bs, QDict *options, int flags)
|
|
|
9ae3a8 |
* XXX(hch): right now these functions are extremely inefficient.
|
|
|
9ae3a8 |
* We should just read the whole bitmap we'll need in one go instead.
|
|
|
9ae3a8 |
*/
|
|
|
9ae3a8 |
-static inline int cow_set_bit(BlockDriverState *bs, int64_t bitnum)
|
|
|
9ae3a8 |
+static inline int cow_set_bit(BlockDriverState *bs, int64_t bitnum, bool *first)
|
|
|
9ae3a8 |
{
|
|
|
9ae3a8 |
uint64_t offset = sizeof(struct cow_header_v2) + bitnum / 8;
|
|
|
9ae3a8 |
uint8_t bitmap;
|
|
|
9ae3a8 |
@@ -117,9 +117,21 @@ static inline int cow_set_bit(BlockDriverState *bs, int64_t bitnum)
|
|
|
9ae3a8 |
return ret;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
+ if (bitmap & (1 << (bitnum % 8))) {
|
|
|
9ae3a8 |
+ return 0;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
+ if (*first) {
|
|
|
9ae3a8 |
+ ret = bdrv_flush(bs->file);
|
|
|
9ae3a8 |
+ if (ret < 0) {
|
|
|
9ae3a8 |
+ return ret;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+ *first = false;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
bitmap |= (1 << (bitnum % 8));
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- ret = bdrv_pwrite_sync(bs->file, offset, &bitmap, sizeof(bitmap));
|
|
|
9ae3a8 |
+ ret = bdrv_pwrite(bs->file, offset, &bitmap, sizeof(bitmap));
|
|
|
9ae3a8 |
if (ret < 0) {
|
|
|
9ae3a8 |
return ret;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
@@ -181,9 +193,10 @@ static int cow_update_bitmap(BlockDriverState *bs, int64_t sector_num,
|
|
|
9ae3a8 |
{
|
|
|
9ae3a8 |
int error = 0;
|
|
|
9ae3a8 |
int i;
|
|
|
9ae3a8 |
+ bool first = true;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
for (i = 0; i < nb_sectors; i++) {
|
|
|
9ae3a8 |
- error = cow_set_bit(bs, sector_num + i);
|
|
|
9ae3a8 |
+ error = cow_set_bit(bs, sector_num + i, &first);
|
|
|
9ae3a8 |
if (error) {
|
|
|
9ae3a8 |
break;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|