|
 |
22c213 |
From 371d312300251c0dc24522607b06b7e47e760b53 Mon Sep 17 00:00:00 2001
|
|
|
22c213 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
22c213 |
Date: Fri, 13 Mar 2020 12:34:32 +0000
|
|
|
22c213 |
Subject: [PATCH 12/20] block: Versioned x-blockdev-reopen API with feature
|
|
|
22c213 |
flag
|
|
|
22c213 |
|
|
|
22c213 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
22c213 |
Message-id: <20200313123439.10548-7-kwolf@redhat.com>
|
|
|
22c213 |
Patchwork-id: 94283
|
|
|
22c213 |
O-Subject: [RHEL-AV-8.2.0 qemu-kvm PATCH v2 06/13] block: Versioned x-blockdev-reopen API with feature flag
|
|
|
22c213 |
Bugzilla: 1790482 1805143
|
|
|
22c213 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
22c213 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
22c213 |
RH-Acked-by: Daniel P. Berrange <berrange@redhat.com>
|
|
|
22c213 |
RH-Acked-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
22c213 |
|
|
|
22c213 |
x-blockdev-reopen is still considered unstable upstream. libvirt needs
|
|
|
22c213 |
(a small subset of) it for incremental backups, though.
|
|
|
22c213 |
|
|
|
22c213 |
Add a downstream-only feature flag that effectively makes this a
|
|
|
22c213 |
versioned interface. As long as the feature is present, we promise that
|
|
|
22c213 |
we won't change the interface incompatibly. Incompatible changes to the
|
|
|
22c213 |
command will require us to drop the feature flag (and possibly introduce
|
|
|
22c213 |
a new one if the new version is still not stable upstream).
|
|
|
22c213 |
|
|
|
22c213 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
22c213 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
22c213 |
---
|
|
|
22c213 |
qapi/block-core.json | 9 ++++++++-
|
|
|
22c213 |
1 file changed, 8 insertions(+), 1 deletion(-)
|
|
|
22c213 |
|
|
|
22c213 |
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
|
22c213 |
index 0cf68fe..a1e85b0 100644
|
|
|
22c213 |
--- a/qapi/block-core.json
|
|
|
22c213 |
+++ b/qapi/block-core.json
|
|
|
22c213 |
@@ -4202,10 +4202,17 @@
|
|
|
22c213 |
# image does not have a default backing file name as part of its
|
|
|
22c213 |
# metadata.
|
|
|
22c213 |
#
|
|
|
22c213 |
+# Features:
|
|
|
22c213 |
+# @__com.redhat_rhel-av-8_2_0-api: Versioning the downstream interface while
|
|
|
22c213 |
+# it's still unstable upstream. As long as
|
|
|
22c213 |
+# this flag is present, this command will not
|
|
|
22c213 |
+# change incompatibly.
|
|
|
22c213 |
+#
|
|
|
22c213 |
# Since: 4.0
|
|
|
22c213 |
##
|
|
|
22c213 |
{ 'command': 'x-blockdev-reopen',
|
|
|
22c213 |
- 'data': 'BlockdevOptions', 'boxed': true }
|
|
|
22c213 |
+ 'data': 'BlockdevOptions', 'boxed': true,
|
|
|
22c213 |
+ 'features': [ '__com.redhat_rhel-av-8_2_0-api' ] }
|
|
|
22c213 |
|
|
|
22c213 |
##
|
|
|
22c213 |
# @blockdev-del:
|
|
|
22c213 |
--
|
|
|
22c213 |
1.8.3.1
|
|
|
22c213 |
|