|
 |
9ae3a8 |
From 1bb88d69e0ad951f9436a79e5a5d4bb35bf4076d Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 6 Nov 2013 14:41:15 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 39/81] apic: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1383748882-22831-11-git-send-email-kwolf@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 55536
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.0 qemu-kvm PATCH v2 10/17] apic: Document why cannot_instantiate_with_device_add_yet
|
|
|
9ae3a8 |
Bugzilla: 1001216
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
9ae3a8 |
(cherry picked from pending upstream submission)
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/intc/apic_common.c | 6 +++++-
|
|
|
9ae3a8 |
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/intc/apic_common.c | 6 +++++-
|
|
|
9ae3a8 |
1 files changed, 5 insertions(+), 1 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
|
|
|
9ae3a8 |
index 208e7b1..ff413de 100644
|
|
|
9ae3a8 |
--- a/hw/intc/apic_common.c
|
|
|
9ae3a8 |
+++ b/hw/intc/apic_common.c
|
|
|
9ae3a8 |
@@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass, void *data)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
dc->vmsd = &vmstate_apic_common;
|
|
|
9ae3a8 |
dc->reset = apic_reset_common;
|
|
|
9ae3a8 |
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
|
|
|
9ae3a8 |
dc->props = apic_properties_common;
|
|
|
9ae3a8 |
idc->init = apic_init_common;
|
|
|
9ae3a8 |
+ /*
|
|
|
9ae3a8 |
+ * Reason: APIC and CPU need to be wired up by
|
|
|
9ae3a8 |
+ * x86_cpu_apic_create()
|
|
|
9ae3a8 |
+ */
|
|
|
9ae3a8 |
+ dc->cannot_instantiate_with_device_add_yet = true;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
static const TypeInfo apic_common_type = {
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|