|
 |
0a122b |
From f58c7c6f3574f28df445c67a378aec5a33285374 Mon Sep 17 00:00:00 2001
|
|
|
0a122b |
From: Orit Wasserman <owasserm@redhat.com>
|
|
|
0a122b |
Date: Tue, 11 Feb 2014 15:32:36 +0100
|
|
|
0a122b |
Subject: [PATCH 15/28] Don't abort on out of memory when creating page cache
|
|
|
0a122b |
|
|
|
0a122b |
RH-Author: Orit Wasserman <owasserm@redhat.com>
|
|
|
0a122b |
Message-id: <1392132757-18587-3-git-send-email-owasserm@redhat.com>
|
|
|
0a122b |
Patchwork-id: 57210
|
|
|
0a122b |
O-Subject: [RHEL7 qemu-kvm PATCH 2/3] Don't abort on out of memory when creating page cache
|
|
|
0a122b |
Bugzilla: 1047448
|
|
|
0a122b |
RH-Acked-by: Dr. David Alan Gilbert (git) <dgilbert@redhat.com>
|
|
|
0a122b |
RH-Acked-by: Juan Quintela <quintela@redhat.com>
|
|
|
0a122b |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
0a122b |
|
|
|
0a122b |
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
|
|
|
0a122b |
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
0a122b |
Signed-off-by: Juan Quintela <quintela@redhat.com>
|
|
|
0a122b |
(cherry picked from commit a17b2fd3580d1da96e806c8b58e61255e8c57577)
|
|
|
0a122b |
---
|
|
|
0a122b |
arch_init.c | 18 ++++++++++++++++--
|
|
|
0a122b |
page_cache.c | 18 ++++++++++++++----
|
|
|
0a122b |
2 files changed, 30 insertions(+), 6 deletions(-)
|
|
|
0a122b |
|
|
|
0a122b |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
0a122b |
---
|
|
|
0a122b |
arch_init.c | 18 ++++++++++++++++--
|
|
|
0a122b |
page_cache.c | 18 ++++++++++++++----
|
|
|
0a122b |
2 files changed, 30 insertions(+), 6 deletions(-)
|
|
|
0a122b |
|
|
|
0a122b |
diff --git a/arch_init.c b/arch_init.c
|
|
|
0a122b |
index c3207bf..fc0f569 100644
|
|
|
0a122b |
--- a/arch_init.c
|
|
|
0a122b |
+++ b/arch_init.c
|
|
|
0a122b |
@@ -659,8 +659,22 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
|
|
|
0a122b |
DPRINTF("Error creating cache\n");
|
|
|
0a122b |
return -1;
|
|
|
0a122b |
}
|
|
|
0a122b |
- XBZRLE.encoded_buf = g_malloc0(TARGET_PAGE_SIZE);
|
|
|
0a122b |
- XBZRLE.current_buf = g_malloc(TARGET_PAGE_SIZE);
|
|
|
0a122b |
+
|
|
|
0a122b |
+ /* We prefer not to abort if there is no memory */
|
|
|
0a122b |
+ XBZRLE.encoded_buf = g_try_malloc0(TARGET_PAGE_SIZE);
|
|
|
0a122b |
+ if (!XBZRLE.encoded_buf) {
|
|
|
0a122b |
+ DPRINTF("Error allocating encoded_buf\n");
|
|
|
0a122b |
+ return -1;
|
|
|
0a122b |
+ }
|
|
|
0a122b |
+
|
|
|
0a122b |
+ XBZRLE.current_buf = g_try_malloc(TARGET_PAGE_SIZE);
|
|
|
0a122b |
+ if (!XBZRLE.current_buf) {
|
|
|
0a122b |
+ DPRINTF("Error allocating current_buf\n");
|
|
|
0a122b |
+ g_free(XBZRLE.encoded_buf);
|
|
|
0a122b |
+ XBZRLE.encoded_buf = NULL;
|
|
|
0a122b |
+ return -1;
|
|
|
0a122b |
+ }
|
|
|
0a122b |
+
|
|
|
0a122b |
acct_clear();
|
|
|
0a122b |
}
|
|
|
0a122b |
|
|
|
0a122b |
diff --git a/page_cache.c b/page_cache.c
|
|
|
0a122b |
index 938a79c..2920123 100644
|
|
|
0a122b |
--- a/page_cache.c
|
|
|
0a122b |
+++ b/page_cache.c
|
|
|
0a122b |
@@ -61,8 +61,12 @@ PageCache *cache_init(int64_t num_pages, unsigned int page_size)
|
|
|
0a122b |
return NULL;
|
|
|
0a122b |
}
|
|
|
0a122b |
|
|
|
0a122b |
- cache = g_malloc(sizeof(*cache));
|
|
|
0a122b |
-
|
|
|
0a122b |
+ /* We prefer not to abort if there is no memory */
|
|
|
0a122b |
+ cache = g_try_malloc(sizeof(*cache));
|
|
|
0a122b |
+ if (!cache) {
|
|
|
0a122b |
+ DPRINTF("Failed to allocate cache\n");
|
|
|
0a122b |
+ return NULL;
|
|
|
0a122b |
+ }
|
|
|
0a122b |
/* round down to the nearest power of 2 */
|
|
|
0a122b |
if (!is_power_of_2(num_pages)) {
|
|
|
0a122b |
num_pages = pow2floor(num_pages);
|
|
|
0a122b |
@@ -75,8 +79,14 @@ PageCache *cache_init(int64_t num_pages, unsigned int page_size)
|
|
|
0a122b |
|
|
|
0a122b |
DPRINTF("Setting cache buckets to %" PRId64 "\n", cache->max_num_items);
|
|
|
0a122b |
|
|
|
0a122b |
- cache->page_cache = g_malloc((cache->max_num_items) *
|
|
|
0a122b |
- sizeof(*cache->page_cache));
|
|
|
0a122b |
+ /* We prefer not to abort if there is no memory */
|
|
|
0a122b |
+ cache->page_cache = g_try_malloc((cache->max_num_items) *
|
|
|
0a122b |
+ sizeof(*cache->page_cache));
|
|
|
0a122b |
+ if (!cache->page_cache) {
|
|
|
0a122b |
+ DPRINTF("Failed to allocate cache->page_cache\n");
|
|
|
0a122b |
+ g_free(cache);
|
|
|
0a122b |
+ return NULL;
|
|
|
0a122b |
+ }
|
|
|
0a122b |
|
|
|
0a122b |
for (i = 0; i < cache->max_num_items; i++) {
|
|
|
0a122b |
cache->page_cache[i].it_data = NULL;
|
|
|
0a122b |
--
|
|
|
0a122b |
1.7.1
|
|
|
0a122b |
|