|
 |
594167 |
From d947339b49eb7935ce282e808a7e75a6098d088a Mon Sep 17 00:00:00 2001
|
|
|
594167 |
From: Yu Watanabe <watanabe.yu+github@gmail.com>
|
|
|
594167 |
Date: Tue, 22 Feb 2022 21:11:51 +0900
|
|
|
594167 |
Subject: [PATCH] test: fix file descriptor leak in test-catalog
|
|
|
594167 |
|
|
|
594167 |
Fixes an issue reported in #22576.
|
|
|
594167 |
|
|
|
594167 |
(cherry picked from commit 62d4b3b36e9aba9e605ba042a75c374155b6e18b)
|
|
|
594167 |
Related: #2087652
|
|
|
594167 |
---
|
|
|
594167 |
src/libsystemd/sd-journal/test-catalog.c | 3 ++-
|
|
|
594167 |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
594167 |
|
|
|
594167 |
diff --git a/src/libsystemd/sd-journal/test-catalog.c b/src/libsystemd/sd-journal/test-catalog.c
|
|
|
594167 |
index 316c3b1634..ad06221175 100644
|
|
|
594167 |
--- a/src/libsystemd/sd-journal/test-catalog.c
|
|
|
594167 |
+++ b/src/libsystemd/sd-journal/test-catalog.c
|
|
|
594167 |
@@ -196,6 +196,7 @@ static void test_catalog_file_lang(void) {
|
|
|
594167 |
|
|
|
594167 |
int main(int argc, char *argv[]) {
|
|
|
594167 |
_cleanup_(unlink_tempfilep) char database[] = "/tmp/test-catalog.XXXXXX";
|
|
|
594167 |
+ _cleanup_close_ int fd = -1;
|
|
|
594167 |
_cleanup_free_ char *text = NULL;
|
|
|
594167 |
int r;
|
|
|
594167 |
|
|
|
594167 |
@@ -218,7 +219,7 @@ int main(int argc, char *argv[]) {
|
|
|
594167 |
test_catalog_import_merge();
|
|
|
594167 |
test_catalog_import_merge_no_body();
|
|
|
594167 |
|
|
|
594167 |
- assert_se(mkostemp_safe(database) >= 0);
|
|
|
594167 |
+ assert_se((fd = mkostemp_safe(database)) >= 0);
|
|
|
594167 |
|
|
|
594167 |
test_catalog_update(database);
|
|
|
594167 |
|