From b53f89d56a5b7528735ddf335f8b47ab3e1a947a Mon Sep 17 00:00:00 2001

From: Lennart Poettering <lennart@poettering.net>

Date: Fri, 19 Oct 2018 11:31:37 +0200

Subject: [PATCH] test: add test case for recursive chown()ing

[msekleta: I removed call to log_test_skipped() and replaced it with older construct log_info() + return EXIT_TEST_SKIP]

(cherry-picked from commit cb9e44db36caefcbb8ee7a12e14217305ed69ff2)

Related: #1643368

---

 src/test/meson.build      |   5 ++

 src/test/test-chown-rec.c | 162 ++++++++++++++++++++++++++++++++++++++

 2 files changed, 167 insertions(+)

 create mode 100644 src/test/test-chown-rec.c

diff --git a/src/test/meson.build b/src/test/meson.build

index 7da7e3a22c..b982251b1f 100644

--- a/src/test/meson.build

+++ b/src/test/meson.build

@@ -60,6 +60,11 @@ tests += [

           libmount,

           libblkid]],

+        [['src/test/test-chown-rec.c'],

+         [libcore,

+          libshared],

+         []],

+

         [['src/test/test-job-type.c'],

          [libcore,

           libshared],

diff --git a/src/test/test-chown-rec.c b/src/test/test-chown-rec.c

new file mode 100644

index 0000000000..f16d4d4ba2

--- /dev/null

+++ b/src/test/test-chown-rec.c

@@ -0,0 +1,162 @@

+/* SPDX-License-Identifier: LGPL-2.1+ */

+

+#include <sys/xattr.h>

+

+#include "alloc-util.h"

+#include "chown-recursive.h"

+#include "fileio.h"

+#include "log.h"

+#include "rm-rf.h"

+#include "string-util.h"

+#include "tests.h"

+

+static const uint8_t acl[] = {

+        0x02, 0x00, 0x00, 0x00, 0x01, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x02, 0x00, 0x07, 0x00,

+        0x02, 0x00, 0x00, 0x00, 0x04, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x10, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x20, 0x00, 0x05, 0x00,

+        0xff, 0xff, 0xff, 0xff,

+};

+

+static const uint8_t default_acl[] = {

+        0x02, 0x00, 0x00, 0x00, 0x01, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x04, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x08, 0x00, 0x07, 0x00,

+        0x04, 0x00, 0x00, 0x00, 0x10, 0x00, 0x07, 0x00,

+        0xff, 0xff, 0xff, 0xff, 0x20, 0x00, 0x05, 0x00,

+        0xff, 0xff, 0xff, 0xff,

+};

+

+static bool has_xattr(const char *p) {

+        char buffer[sizeof(acl) * 4];

+

+        if (lgetxattr(p, "system.posix_acl_access", buffer, sizeof(buffer)) < 0) {

+                if (IN_SET(errno, EOPNOTSUPP, ENOTTY, ENODATA, ENOSYS))

+                        return false;

+        }

+

+        return true;

+}

+

+static void test_chown_recursive(void) {

+        _cleanup_(rm_rf_physical_and_freep) char *t = NULL;

+        struct stat st;

+        const char *p;

+

+        umask(022);

+        assert_se(mkdtemp_malloc(NULL, &t) >= 0);

+

+        p = strjoina(t, "/dir");

+        assert_se(mkdir(p, 0777) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISDIR(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/symlink");

+        assert_se(symlink("../../", p) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISLNK(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0777);

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/reg");

+        assert_se(mknod(p, S_IFREG|0777, 0) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISREG(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/sock");

+        assert_se(mknod(p, S_IFSOCK|0777, 0) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISSOCK(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/fifo");

+        assert_se(mknod(p, S_IFIFO|0777, 0) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISFIFO(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(!has_xattr(p));

+

+        /* We now apply an xattr to the dir, and check it again */

+        p = strjoina(t, "/dir");

+        assert_se(setxattr(p, "system.posix_acl_access", acl, sizeof(acl), 0) >= 0);

+        assert_se(setxattr(p, "system.posix_acl_default", default_acl, sizeof(default_acl), 0) >= 0);

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISDIR(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0775); /* acl change changed the mode too */

+        assert_se(st.st_uid == 0);

+        assert_se(st.st_gid == 0);

+        assert_se(has_xattr(p));

+

+        assert_se(path_chown_recursive(t, 1, 2) >= 0);

+

+        p = strjoina(t, "/dir");

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISDIR(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0775);

+        assert_se(st.st_uid == 1);

+        assert_se(st.st_gid == 2);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/symlink");

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISLNK(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0777);

+        assert_se(st.st_uid == 1);

+        assert_se(st.st_gid == 2);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/reg");

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISREG(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 1);

+        assert_se(st.st_gid == 2);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/sock");

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISSOCK(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 1);

+        assert_se(st.st_gid == 2);

+        assert_se(!has_xattr(p));

+

+        p = strjoina(t, "/dir/fifo");

+        assert_se(lstat(p, &st) >= 0);

+        assert_se(S_ISFIFO(st.st_mode));

+        assert_se((st.st_mode & 07777) == 0755);

+        assert_se(st.st_uid == 1);

+        assert_se(st.st_gid == 2);

+        assert_se(!has_xattr(p));

+}

+

+int main(int argc, char *argv[]) {

+        log_set_max_level(LOG_DEBUG);

+        log_parse_environment();

+        log_open();

+

+        if (geteuid() != 0) {

+                log_info("not running as root");

+                return EXIT_TEST_SKIP;

+        }

+

+        test_chown_recursive();

+

+        return EXIT_SUCCESS;

+}