sailesh1993 / rpms / cloud-init

Forked from rpms/cloud-init 10 months ago
Clone
16d12a
From f15946568fe731dc9bf477f3f06c9c4e0f74f7c1 Mon Sep 17 00:00:00 2001
c1c26e
From: Lars Kellogg-Stedman <lars@redhat.com>
c1c26e
Date: Fri, 7 Apr 2017 18:50:54 -0400
c1c26e
Subject: limit permissions on def_log_file
c1c26e
c1c26e
This sets a default mode of 0600 on def_log_file, and makes this
c1c26e
configurable via the def_log_file_mode option in cloud.cfg.
c1c26e
c1c26e
LP: #1541196
c1c26e
Resolves: rhbz#1424612
c1c26e
X-approved-upstream: true
c1c26e
---
c1c26e
 cloudinit/settings.py         | 1 +
c1c26e
 cloudinit/stages.py           | 3 ++-
c1c26e
 doc/examples/cloud-config.txt | 4 ++++
c1c26e
 3 files changed, 7 insertions(+), 1 deletion(-)
c1c26e
c1c26e
diff --git a/cloudinit/settings.py b/cloudinit/settings.py
16d12a
index 3a04a58..439eee0 100644
c1c26e
--- a/cloudinit/settings.py
c1c26e
+++ b/cloudinit/settings.py
16d12a
@@ -45,6 +45,7 @@ CFG_BUILTIN = {
c1c26e
         'None',
c1c26e
     ],
c1c26e
     'def_log_file': '/var/log/cloud-init.log',
c1c26e
+    'def_log_file_mode': 0o600,
c1c26e
     'log_cfgs': [],
c1c26e
     'mount_default_fields': [None, None, 'auto', 'defaults,nofail', '0', '2'],
c1c26e
     'ssh_deletekeys': False,
c1c26e
diff --git a/cloudinit/stages.py b/cloudinit/stages.py
16d12a
index 71f3a49..68b83af 100644
c1c26e
--- a/cloudinit/stages.py
c1c26e
+++ b/cloudinit/stages.py
16d12a
@@ -149,8 +149,9 @@ class Init(object):
c1c26e
     def _initialize_filesystem(self):
c1c26e
         util.ensure_dirs(self._initial_subdirs())
c1c26e
         log_file = util.get_cfg_option_str(self.cfg, 'def_log_file')
c1c26e
+        log_file_mode = util.get_cfg_option_int(self.cfg, 'def_log_file_mode')
c1c26e
         if log_file:
c1c26e
-            util.ensure_file(log_file)
c1c26e
+            util.ensure_file(log_file, mode=log_file_mode)
c1c26e
             perms = self.cfg.get('syslog_fix_perms')
c1c26e
             if not perms:
c1c26e
                 perms = {}
c1c26e
diff --git a/doc/examples/cloud-config.txt b/doc/examples/cloud-config.txt
16d12a
index eb84dcf..0e82b83 100644
c1c26e
--- a/doc/examples/cloud-config.txt
c1c26e
+++ b/doc/examples/cloud-config.txt
c1c26e
@@ -413,10 +413,14 @@ timezone: US/Eastern
c1c26e
 # if syslog_fix_perms is a list, it will iterate through and use the
c1c26e
 # first pair that does not raise error.
c1c26e
 #
c1c26e
+# 'def_log_file' will be created with mode 'def_log_file_mode', which
c1c26e
+# is specified as a numeric value and defaults to 0600.
c1c26e
+#
c1c26e
 # the default values are '/var/log/cloud-init.log' and 'syslog:adm'
c1c26e
 # the value of 'def_log_file' should match what is configured in logging
c1c26e
 # if either is empty, then no change of ownership will be done
c1c26e
 def_log_file: /var/log/my-logging-file.log
c1c26e
+def_log_file_mode: 0600
c1c26e
 syslog_fix_perms: syslog:root
c1c26e
 
c1c26e
 # you can set passwords for a user or multiple users
c1c26e
-- 
16d12a
1.8.3.1
c1c26e