|
 |
1ff636 |
From 529c94b47f886f99796cff0f5827d6c2ebdcea19 Mon Sep 17 00:00:00 2001
|
|
|
1ff636 |
From: Lennart Poettering <lennart@poettering.net>
|
|
|
1ff636 |
Date: Mon, 2 Mar 2015 20:55:38 +0100
|
|
|
1ff636 |
Subject: [PATCH] sd-daemon: replace VLA with alloca(), to make llvm happy
|
|
|
1ff636 |
|
|
|
1ff636 |
https://bugs.freedesktop.org/show_bug.cgi?id=89379
|
|
|
1ff636 |
(cherry picked from commit d4a144fadf89bca681724c6c9a65b4a165fa0f90)
|
|
|
1ff636 |
---
|
|
|
1ff636 |
src/libsystemd/sd-daemon/sd-daemon.c | 12 +++++-------
|
|
|
1ff636 |
1 file changed, 5 insertions(+), 7 deletions(-)
|
|
|
1ff636 |
|
|
|
1ff636 |
diff --git a/src/libsystemd/sd-daemon/sd-daemon.c b/src/libsystemd/sd-daemon/sd-daemon.c
|
|
|
1ff636 |
index 028c2a7..22a3a53 100644
|
|
|
1ff636 |
--- a/src/libsystemd/sd-daemon/sd-daemon.c
|
|
|
1ff636 |
+++ b/src/libsystemd/sd-daemon/sd-daemon.c
|
|
|
1ff636 |
@@ -352,11 +352,7 @@ _public_ int sd_pid_notify_with_fds(pid_t pid, int unset_environment, const char
|
|
|
1ff636 |
.msg_iovlen = 1,
|
|
|
1ff636 |
.msg_name = &sockaddr,
|
|
|
1ff636 |
};
|
|
|
1ff636 |
- union {
|
|
|
1ff636 |
- struct cmsghdr cmsghdr;
|
|
|
1ff636 |
- uint8_t buf[CMSG_SPACE(sizeof(struct ucred)) +
|
|
|
1ff636 |
- CMSG_SPACE(sizeof(int) * n_fds)];
|
|
|
1ff636 |
- } control;
|
|
|
1ff636 |
+ struct cmsghdr *control;
|
|
|
1ff636 |
_cleanup_close_ int fd = -1;
|
|
|
1ff636 |
struct cmsghdr *cmsg = NULL;
|
|
|
1ff636 |
const char *e;
|
|
|
1ff636 |
@@ -400,8 +396,10 @@ _public_ int sd_pid_notify_with_fds(pid_t pid, int unset_environment, const char
|
|
|
1ff636 |
if (msghdr.msg_namelen > sizeof(struct sockaddr_un))
|
|
|
1ff636 |
msghdr.msg_namelen = sizeof(struct sockaddr_un);
|
|
|
1ff636 |
|
|
|
1ff636 |
+ control = alloca(CMSG_SPACE(sizeof(struct ucred)) + CMSG_SPACE(sizeof(int) * n_fds));
|
|
|
1ff636 |
+
|
|
|
1ff636 |
if (n_fds > 0) {
|
|
|
1ff636 |
- msghdr.msg_control = &control;
|
|
|
1ff636 |
+ msghdr.msg_control = control;
|
|
|
1ff636 |
msghdr.msg_controllen = CMSG_LEN(sizeof(int) * n_fds);
|
|
|
1ff636 |
|
|
|
1ff636 |
cmsg = CMSG_FIRSTHDR(&msghdr);
|
|
|
1ff636 |
@@ -418,7 +416,7 @@ _public_ int sd_pid_notify_with_fds(pid_t pid, int unset_environment, const char
|
|
|
1ff636 |
try_without_ucred = true;
|
|
|
1ff636 |
controllen_without_ucred = msghdr.msg_controllen;
|
|
|
1ff636 |
|
|
|
1ff636 |
- msghdr.msg_control = &control;
|
|
|
1ff636 |
+ msghdr.msg_control = control;
|
|
|
1ff636 |
msghdr.msg_controllen += CMSG_LEN(sizeof(struct ucred));
|
|
|
1ff636 |
|
|
|
1ff636 |
if (cmsg)
|