From 2b347169b9046ff2d735ef23e62a8c74f5151600 Mon Sep 17 00:00:00 2001

From: Philippe De Swert <philippedeswert@gmail.com>

Date: Wed, 10 Sep 2014 12:20:42 +0300

Subject: [PATCH] bus: unref buscreds on failure

Actually unref the buscreds when we are not going to return a

pointer to them. As when bus_creds_add_more fails we immediately

return the error code otherwise and leak the new buscreds.

Found with coverity. Fixes: CID#1237761

---

 src/libsystemd/sd-bus/sd-bus.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c

index 78e91b9654..83b3aa1c3c 100644

--- a/src/libsystemd/sd-bus/sd-bus.c

+++ b/src/libsystemd/sd-bus/sd-bus.c

@@ -3339,8 +3339,10 @@ _public_ int sd_bus_get_peer_creds(sd_bus *bus, uint64_t mask, sd_bus_creds **re

         }

         r = bus_creds_add_more(c, mask, pid, 0);

-        if (r < 0)

+        if (r < 0) {

+                sd_bus_creds_unref(c);

                 return r;

+        }

         *ret = c;

         return 0;