richardphibel / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
17aa40
From b0c226e9fd3e6bfa5388832cc2745d9ec935f3ec Mon Sep 17 00:00:00 2001
eb8b6e
From: Michal Sekletar <msekleta@redhat.com>
eb8b6e
Date: Mon, 4 Oct 2021 20:31:49 +0200
eb8b6e
Subject: [PATCH] mount: retrigger run queue after ratelimit expired to run
eb8b6e
 delayed mount start jobs
eb8b6e
eb8b6e
Fixes #20329
eb8b6e
eb8b6e
(cherry picked from commit edc027b4f1cfaa49e8ecdde763eb8c623402d464)
eb8b6e
17aa40
Related: #2036608
eb8b6e
---
eb8b6e
 src/core/mount.c | 21 +++++++++++++++++++++
eb8b6e
 1 file changed, 21 insertions(+)
eb8b6e
eb8b6e
diff --git a/src/core/mount.c b/src/core/mount.c
17aa40
index ab09e6fbb0..bdba9e6884 100644
eb8b6e
--- a/src/core/mount.c
eb8b6e
+++ b/src/core/mount.c
17aa40
@@ -1710,6 +1710,21 @@ static bool mount_is_mounted(Mount *m) {
eb8b6e
         return UNIT(m)->perpetual || m->is_mounted;
eb8b6e
 }
eb8b6e
 
eb8b6e
+static int mount_on_ratelimit_expire(sd_event_source *s, void *userdata) {
eb8b6e
+        Manager *m = userdata;
eb8b6e
+        int r;
eb8b6e
+
eb8b6e
+        assert(m);
eb8b6e
+
eb8b6e
+        /* By entering ratelimited state we made all mount start jobs not runnable, now rate limit is over so let's
eb8b6e
+         * make sure we dispatch them in the next iteration. */
eb8b6e
+        r = sd_event_source_set_enabled(m->run_queue_event_source, SD_EVENT_ONESHOT);
eb8b6e
+        if (r < 0)
eb8b6e
+                log_debug_errno(r, "Failed to enable run queue event source, ignoring: %m");
eb8b6e
+
eb8b6e
+        return 0;
eb8b6e
+}
eb8b6e
+
eb8b6e
 static void mount_enumerate(Manager *m) {
eb8b6e
         int r;
eb8b6e
 
17aa40
@@ -1763,6 +1778,12 @@ static void mount_enumerate(Manager *m) {
eb8b6e
                         goto fail;
eb8b6e
                 }
eb8b6e
 
eb8b6e
+                r = sd_event_source_set_ratelimit_expire_callback(m->mount_event_source, mount_on_ratelimit_expire);
eb8b6e
+                if (r < 0) {
eb8b6e
+                         log_error_errno(r, "Failed to enable rate limit for mount events: %m");
eb8b6e
+                         goto fail;
eb8b6e
+                }
eb8b6e
+
eb8b6e
                 (void) sd_event_source_set_description(m->mount_event_source, "mount-monitor-dispatch");
eb8b6e
         }
eb8b6e