richardphibel / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
594167
From c81dea716e04419f8f7b83346015ae8f834ec30c Mon Sep 17 00:00:00 2001
594167
From: Frantisek Sumsal <frantisek@sumsal.cz>
594167
Date: Mon, 20 Jun 2022 12:27:39 +0200
594167
Subject: [PATCH] test: use saved process PID instead of %%
594167
594167
As the `%%` specifier might fail if the current job (i.e. the last
594167
background job) already finished:
594167
594167
```
594167
[   61.692196] testsuite-04.sh[656]: ++ systemd-id128 new
594167
[   61.705407] testsuite-04.sh[263]: + ID=912cb8f8ef304153a123f772bb0fe9e0
594167
[   61.706318] testsuite-04.sh[657]: + systemd-cat -t 912cb8f8ef304153a123f772bb0fe9e0 bash -c 'echo parent; (echo child) & wait'
594167
[   61.720940] testsuite-04.sh[263]: + PID=657
594167
[   61.721126] testsuite-04.sh[263]: + wait %%
594167
[   61.723014] testsuite-04.sh[263]: /usr/lib/systemd/tests/testdata/units/testsuite-04.sh: line 96: wait: %%: no such job
594167
```
594167
594167
(cherry picked from commit 08970485003c25ce2c4adfaeea2d58558d311d42)
594167
594167
Related: #2087652
594167
---
594167
 test/units/testsuite-04.sh | 2 +-
594167
 1 file changed, 1 insertion(+), 1 deletion(-)
594167
594167
diff --git a/test/units/testsuite-04.sh b/test/units/testsuite-04.sh
594167
index 7521a6d2e5..b5468cbea4 100755
594167
--- a/test/units/testsuite-04.sh
594167
+++ b/test/units/testsuite-04.sh
594167
@@ -93,7 +93,7 @@ cmp /expected /output
594167
 ID=$(systemd-id128 new)
594167
 systemd-cat -t "$ID" bash -c 'echo parent; (echo child) & wait' &
594167
 PID=$!
594167
-wait %%
594167
+wait $PID
594167
 journalctl --sync
594167
 # We can drop this grep when https://github.com/systemd/systemd/issues/13937
594167
 # has a fix.